Re: [quicwg/base-drafts] TP to disable migration (#1447)

janaiyengar <notifications@github.com> Tue, 19 June 2018 00:25 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8B160130F67 for <quic-issues@ietfa.amsl.com>; Mon, 18 Jun 2018 17:25:04 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2xbSPIZLaVKk for <quic-issues@ietfa.amsl.com>; Mon, 18 Jun 2018 17:25:02 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9CE91130EA1 for <quic-issues@ietf.org>; Mon, 18 Jun 2018 17:25:02 -0700 (PDT)
Date: Mon, 18 Jun 2018 17:25:01 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1529367901; bh=5IrQSFHWxpuXTAYhxgbYg7wMuj6D1wbaq49NS4TDBvA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=P6jARyOgWyfB4HMkb3wzC3hOWA8zNyi6lkeu2luP70vm7eqbBsQHrGVOAW0x6zstb 0ItSLbPRwhyez7JaZyrgG86YQMzZAfJ5EQHWQeJjotNgaPjsgARUgbHfM5s01UJViw NZDKxUScK8wt1h1gf0tvuWIbe1DYXaBe9MVyWEXE=
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab13ba31a2736d6fdcf2bd2a93b90f2e1fa09d377b92cf0000000117400f5d92a169ce13d3250f@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1447/review/129782442@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1447@github.com>
References: <quicwg/base-drafts/pull/1447@github.com>
Subject: Re: [quicwg/base-drafts] TP to disable migration (#1447)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b284d5df1aac_73463f80a4f70f802448fd"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/2ZldebwhZIs6cIepji52y78tS4w>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Jun 2018 00:25:05 -0000

janaiyengar commented on this pull request.

One comment inline. Also, I would suggest (as I did in my comment on the issue) that: (i) a server should be allowed to detect a client violation of this TP and close the connection with PROTOCOL_VIOLATION (or a new error if this doesn't sit well with folks), (ii) the text should make it clear that a NAT rebinding may still result in path validation.

> @@ -1289,6 +1290,13 @@ preferred_address (0x0004):
 : The server's Preferred Address is used to effect a change in server address at
   the end of the handshake, as described in {{preferred-address}}.
 
+disable_migration (0x0009):
+
+: The server does not support connection migration ({{migration}}). Clients MUST

It's true that we only support client-driven migrations, but I think there's value in keeping most of the text agnostic to polarity. Is there a reason to disallow this TP in the opposite direction? It'll be a NO-OP, but we don't need to disallow it, I think.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1447#pullrequestreview-129782442