Re: [quicwg/base-drafts] TP to disable migration (#1447)

erickinnear <notifications@github.com> Fri, 22 June 2018 17:44 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 94922130EB0 for <quic-issues@ietfa.amsl.com>; Fri, 22 Jun 2018 10:44:52 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Rpj0rQ8xsZgL for <quic-issues@ietfa.amsl.com>; Fri, 22 Jun 2018 10:44:49 -0700 (PDT)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EBA18130E10 for <quic-issues@ietf.org>; Fri, 22 Jun 2018 10:44:48 -0700 (PDT)
Date: Fri, 22 Jun 2018 10:44:48 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1529689488; bh=9cmaUam5c8o9crBFTjsliRk+ZdS6v+sYQOqfX1tvZa4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=dJfZU5kEbxoxAyhjmb95JUJ5tiF+vp3pw3rxHaok+eyZI1v2MqIy37phpaay95RJZ YKOxv2sf+bikbDMNczFfAX4ZjJIpz9SBecZCYibKqM2hk83rs8RF29yxlqQVfR2C+H tUL0gzj50W95SapEalWIEjlvRd3VBP3YlOx6rw5g=
From: erickinnear <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab4498757ec123608552e3ef49d8413a62cadcbfe392cf000000011744f78f92a169ce13d3250f@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1447/review/131286086@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1447@github.com>
References: <quicwg/base-drafts/pull/1447@github.com>
Subject: Re: [quicwg/base-drafts] TP to disable migration (#1447)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b2d358ff3a71_249d2af91c92af503282e7"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: erickinnear
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/5HSC9J1vwGPPbUTpcIrTAubVzgU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Jun 2018 17:44:53 -0000

erickinnear commented on this pull request.



> @@ -1656,7 +1664,12 @@ network.  This section describes the process by which an endpoint migrates to a
 new address.
 
 An endpoint MUST NOT initiate connection migration before the handshake is
-finished and the endpoint has 1-RTT keys.
+finished and the endpoint has 1-RTT keys.  An endpoint also MUST NOT initiate
+connection migration if the peer sent the `disable_migration` transport
+parameter during the handshake.  An endpoint which has sent this transport
+parameter, but detects that a peer has nonetheless migrated to a different
+network MAY treat this as a connection error of type INVALID_MIGRATION.
+However, note that not all changes of peer address are intentional migrations.

Good point! If you send the parameter, you still need to implement a response to path challenge frames, for example. I'll comment on the issue with more thoughts, but the text should at least mention that you still need to be prepared for that to happen. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1447#discussion_r197520017