Re: [quicwg/base-drafts] TP to disable migration (#1447)

ianswett <notifications@github.com> Mon, 18 June 2018 06:46 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D3DAD1292AD for <quic-issues@ietfa.amsl.com>; Sun, 17 Jun 2018 23:46:55 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ydZnGhhnvmQ0 for <quic-issues@ietfa.amsl.com>; Sun, 17 Jun 2018 23:46:54 -0700 (PDT)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3BE73127598 for <quic-issues@ietf.org>; Sun, 17 Jun 2018 23:46:54 -0700 (PDT)
Date: Sun, 17 Jun 2018 23:46:53 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1529304413; bh=wDY4ipGi/BvmuLlbBfXbvNQ+3sqC1MVct89uRmdXb3U=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=pPzE0Ue/s2plU1laBRTWkPkPA9P0mYlDpc5mWQ0BkPNYXaFYe4liacWwNF8GsybPQ lITsqTVimgHoYsnvd5UKI5OfeP7L6JQ357kjZnX6B5TtuR+xyJwjt9pNxAVvP3zUUT guBUct1LLfC96ezEhInhltPUuCZuomOIZgLmkz1s=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab0753cda91299536519bbd97c29e7cd09bbcce9e892cf00000001173f175d92a169ce13d3250f@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1447/review/129441251@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1447@github.com>
References: <quicwg/base-drafts/pull/1447@github.com>
Subject: Re: [quicwg/base-drafts] TP to disable migration (#1447)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b27555d2d5d3_1b082ac41adaef54269426"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/q6ALgvS5hMOfxRM0XQJMmCUjaJU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Jun 2018 06:46:56 -0000

ianswett approved this pull request.

Looks good.  Not giving out connection Ids seems clever, but if that's the only mechanism for disabling migration, then it would seem to discourage people for giving them out for other reasons.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1447#pullrequestreview-129441251