Re: [quicwg/base-drafts] Disconnect with Initial Injection (#1951)

Marten Seemann <notifications@github.com> Fri, 30 November 2018 03:15 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4C5F2126BED for <quic-issues@ietfa.amsl.com>; Thu, 29 Nov 2018 19:15:01 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.46
X-Spam-Level:
X-Spam-Status: No, score=-9.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mCAMUtGgnJLk for <quic-issues@ietfa.amsl.com>; Thu, 29 Nov 2018 19:15:00 -0800 (PST)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DBECF12008A for <quic-issues@ietf.org>; Thu, 29 Nov 2018 19:14:59 -0800 (PST)
Date: Thu, 29 Nov 2018 19:14:59 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1543547699; bh=gJWO5B/PuF7p1ijSXkvTY0v4ZqpTC2lYmbCNvxMOuPc=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=tTuxFfB9HwSe1arVXltswd1x4D5hXq+6C2GWWaXQOE298Kf4SGCgOoUwAZsI9onZP cyS5yeSEXCX6QHI90XLfflJ0Br/58XUeq5SvXImdn07N3XdFFAWik0rPoWK0BXPkVk tAwVUSEio/aFr88JvDSExMeVmPyytWMuHNIWXd3s=
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab9df842c65afce31d4af227e105e40d674377fe2892cf0000000118186d3392a169ce1678fc4e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1951/443076675@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1951@github.com>
References: <quicwg/base-drafts/issues/1951@github.com>
Subject: Re: [quicwg/base-drafts] Disconnect with Initial Injection (#1951)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c00ab33d10e_79c13f93e20d45c04772ab"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/37dNuD_Z_ZCdQ9EJVEt_49vmddI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Nov 2018 03:15:01 -0000

> After the Handshake keys are known, endpoints can ignore ACK frames entirely.

Which requires implicit acking, along the lines of #2045, which I think is the best fix we have for the injection attack.

> Before the Handshake keys are exchanged, you need to rely on ACKs. At that moment, having rules to reject certain ACKs never hurts.

True, but it doesn't fix this issue. There are various ways to defend against injections during the 3-way handshake, and implementations may do something fancy here, but I don't think we have the tools to completely prevent this attack yet.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1951#issuecomment-443076675