Re: [quicwg/base-drafts] Close the connection if MAX_STREAMS is too large (#2499)

Jana Iyengar <notifications@github.com> Thu, 07 March 2019 23:42 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E5B45130FB8 for <quic-issues@ietfa.amsl.com>; Thu, 7 Mar 2019 15:42:16 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1hJ_1hLamUnZ for <quic-issues@ietfa.amsl.com>; Thu, 7 Mar 2019 15:42:15 -0800 (PST)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1F83E13122E for <quic-issues@ietf.org>; Thu, 7 Mar 2019 15:42:15 -0800 (PST)
Date: Thu, 07 Mar 2019 15:42:13 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1552002133; bh=8afZtOwdKKFJQIgZzVn3EBTBSzY6isCmmyVzQWJEOVU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=M8ihpRTBCMYB2MVDX8c8W5/m+oX9VJgktiBWyQWz4Cgb3adRf/F83DSorZBzwnBNL fiiYpfu50CPdwpiqmDWCupr55Gq3zpaH18Ks0j4+zCEv5HV11ddFtKRfl4P4EBUqrG x7g6oJqmPjmbbjfNh2NPd7M5y7DnaZOqbz+3JZn0=
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab86c6ebae8f7d494aebbca8c77ed47e9f6246caa792cf0000000118996e5592a169ce18e318a8@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2499/review/212080205@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2499@github.com>
References: <quicwg/base-drafts/pull/2499@github.com>
Subject: Re: [quicwg/base-drafts] Close the connection if MAX_STREAMS is too large (#2499)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c81ac55adabd_505e3f8e8a8d45c0687c0"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/5kEJw0EeBHgXQQu_9jadGQouqYk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Mar 2019 23:42:21 -0000

janaiyengar commented on this pull request.



> @@ -851,6 +851,11 @@ limits are set in the transport parameters (see
 using MAX_STREAMS frames ({{frame-max-streams}}). Separate limits apply to
 unidirectional and bidirectional streams.
 
+If a max_streams transport parameter or MAX_STREAMS frame carries a value
+greater than 2^60, which implies a maximum stream ID that cannot be expressed,

My addition was (perhaps poorly) trying to articulate the difference between expressing it in transport params/MAX_STREAMS vs. in other frames. Saying that it's not expressible isn't accurate -- it was "expressed" when we received it -- what we want to say is that it's not expressible in other frames, specifically as a varint. 

Maybe what I should have suggested is 
"cannot be expressed as a variable-length integer (see {{integer-encoding}})."

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2499#discussion_r263616643