IETF Logo Mail Archive

Re: [quicwg/base-drafts] Close the connection if MAX_STREAMS is too large (#2499)

ianswett <notifications@github.com> Wed, 13 March 2019 15:48 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5948B130F5B for <quic-issues@ietfa.amsl.com>; Wed, 13 Mar 2019 08:48:50 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.375
X-Spam-Level:
X-Spam-Status: No, score=-0.375 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=0.726, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8vnG_TL0zh0R for <quic-issues@ietfa.amsl.com>; Wed, 13 Mar 2019 08:48:48 -0700 (PDT)
Received: from o9.sgmail.github.com (o9.sgmail.github.com [167.89.101.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D5DA2130F26 for <quic-issues@ietf.org>; Wed, 13 Mar 2019 08:48:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=PHfuCofy8dJB4u3gT+yAO/xDVY8=; b=u0NT3hUWQIo9uUv9 E1iPBBQPTOuRPmfc6jDViGwFb+jCc9Iv3yUvw88E9F0My2O91GNLEkgTWKlFyMN5 rNMcMcD4iTMS0BWWeEaLXuTH6L3FGsdI8ibscVbpGGwmslDmnJJUwA8zAX/OD3mn 8asEY1Lf9h5zkxmwdOU6lPEr4as=
Received: by filter1479p1mdw1.sendgrid.net with SMTP id filter1479p1mdw1-18313-5C892658-1F 2019-03-13 15:48:40.860788897 +0000 UTC m=+144629.042311340
Received: from github-lowworker-e51511d.cp1-iad.github.net (unknown [192.30.252.34]) by ismtpd0043p1mdw1.sendgrid.net (SG) with ESMTP id c8kgtzoyT2e2xnH7kaoEOg for <quic-issues@ietf.org>; Wed, 13 Mar 2019 15:48:40.728 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-e51511d.cp1-iad.github.net (Postfix) with ESMTP id 6D53F80973 for <quic-issues@ietf.org>; Wed, 13 Mar 2019 08:48:40 -0700 (PDT)
Date: Wed, 13 Mar 2019 15:48:40 +0000
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abca3d960708d88d7c93600651e184a47ec4b293dd92cf0000000118a0e85892a169ce18e318a8@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2499/review/214041947@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2499@github.com>
References: <quicwg/base-drafts/pull/2499@github.com>
Subject: Re: [quicwg/base-drafts] Close the connection if MAX_STREAMS is too large (#2499)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c8926586a080_30c3fa09c2d45c049591e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1mP42rLPpvydigj4ja8551lwsMocoRfDSZUU Ira3f+n/xjPq5IwWWLWjWWYE1uzTZwjlD6XTDmvl+H4hQ9wrtH6XZxKb/X/3ZCj9N7IgqLJTkKqKxt 9GD4K4wZ1yARGNNUH76RsY5NcweTnxsZJ+7HZwTOu+awAeVK4M7WRArt5RFe5VC4r5VPJ/v8BaNGzp 0=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/TH3U1Xv3z0imoJ4RpPJR1WSMTj8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Mar 2019 15:49:03 -0000

ianswett commented on this pull request.



> @@ -851,6 +851,12 @@ limits are set in the transport parameters (see
 using MAX_STREAMS frames ({{frame-max-streams}}). Separate limits apply to
 unidirectional and bidirectional streams.
 
+If a max_streams transport parameter or MAX_STREAMS frame is received with a
+value greater than 2^60, this allows a maximum stream ID that cannot be
+expressed as a variable-length integer (see {{integer-encoding}}).

SG, done.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2499#discussion_r265197570

v2.23.0 | Report a Bug | By Email