IETF Logo Mail Archive

Re: [quicwg/base-drafts] Close the connection if MAX_STREAMS is too large (#2499)

Tommy Pauly <notifications@github.com> Wed, 13 March 2019 15:42 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 779EC130F62 for <quic-issues@ietfa.amsl.com>; Wed, 13 Mar 2019 08:42:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.375
X-Spam-Level:
X-Spam-Status: No, score=-5.375 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=0.726, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DnlxU1gqFDR2 for <quic-issues@ietfa.amsl.com>; Wed, 13 Mar 2019 08:41:59 -0700 (PDT)
Received: from out-12.smtp.github.com (out-12.smtp.github.com [192.30.254.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9B515130F17 for <quic-issues@ietf.org>; Wed, 13 Mar 2019 08:41:59 -0700 (PDT)
Date: Wed, 13 Mar 2019 08:41:58 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1552491718; bh=djEdObtO0LwrMp1SvvOZBXFUungnR8LzKU8gYhKr5VA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=r8XlIYmbwdmvpRLQ+XNM2SY+itA841AlcqH8heRcwtD7t40Ve0WnhV5ybio8zxc0m mZE0/PNeNi6FGF1zDlV1+vC9meU0ucC5zhFO/AuSORFf4GftmDr904B8dTRU9RfcAO 9x2BwAOfsFiNzigmDuOf+REHv/R/i1GDNlYu1YmI=
From: Tommy Pauly <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab690084bd9b5a81e2aeedc41377ae3e94017d52c292cf0000000118a0e6c692a169ce18e318a8@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2499/review/214037491@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2499@github.com>
References: <quicwg/base-drafts/pull/2499@github.com>
Subject: Re: [quicwg/base-drafts] Close the connection if MAX_STREAMS is too large (#2499)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c8924c699017_309e3f93e9ed45c42030ef"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: tfpauly
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/73x5UXjvOMb6BFa4u-tsitav1Os>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Mar 2019 15:42:13 -0000

tfpauly commented on this pull request.



> @@ -851,6 +851,12 @@ limits are set in the transport parameters (see
 using MAX_STREAMS frames ({{frame-max-streams}}). Separate limits apply to
 unidirectional and bidirectional streams.
 
+If a max_streams transport parameter or MAX_STREAMS frame is received with a
+value greater than 2^60, this allows a maximum stream ID that cannot be
+expressed as a variable-length integer (see {{integer-encoding}}).

If we're bike-shedding the grammar, I'd vote for `... this would allow a maximum stream ID ...`. Using "would" correlates better to the fact that this is indeed a protocol error and therefore isn't actually allowing anything.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2499#discussion_r265194072

v2.23.0 | Report a Bug | By Email