IETF Logo Mail Archive

Re: [quicwg/base-drafts] Close the connection if MAX_STREAMS is too large (#2499)

Martin Thomson <notifications@github.com> Wed, 06 March 2019 03:33 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 108C71271FF for <quic-issues@ietfa.amsl.com>; Tue, 5 Mar 2019 19:33:34 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.598
X-Spam-Level:
X-Spam-Status: No, score=-6.598 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Hm4IA8Y6Xqdg for <quic-issues@ietfa.amsl.com>; Tue, 5 Mar 2019 19:33:32 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6DCC8127AC2 for <quic-issues@ietf.org>; Tue, 5 Mar 2019 19:33:32 -0800 (PST)
Date: Tue, 05 Mar 2019 19:33:31 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1551843211; bh=SlNJgyQxoeODwxR+3I4F99wo4uI444xAmHVxdxwS5lQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=FPKyk8FEhsppc7vDXPQjTjkw+Oyl+1xlmNOo7CVkoU66o7+2pkhT8oDc3oAMbq9Tm LApl0fNvkLGRO24a4bqR1gMk8b4J95uAvXbhqIelltxKDKegdq1Z85bcLrTn4FlQo5 XZ0Sk5zwYBHfJFJ0kliUXx91yTkLwspUHzssGSfE=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab8bd29d7deb5964486c9fbf1291704bf0b24eac0c92cf000000011897018b92a169ce18e318a8@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2499/review/211030751@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2499@github.com>
References: <quicwg/base-drafts/pull/2499@github.com>
Subject: Re: [quicwg/base-drafts] Close the connection if MAX_STREAMS is too large (#2499)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c7f3f8b94188_46113fd721cd45b4128356"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/RPMjVVax2vjHxJEw6X527rMxNII>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Mar 2019 03:33:34 -0000

martinthomson commented on this pull request.



> @@ -849,7 +849,10 @@ initial_stream_id_for_type) can be opened (see {{long-packet-types}}).  Initial
 limits are set in the transport parameters (see
 {{transport-parameter-definitions}}) and subsequently limits are advertised
 using MAX_STREAMS frames ({{frame-max-streams}}). Separate limits apply to
-unidirectional and bidirectional streams.
+unidirectional and bidirectional streams. When a MAX_STREAMS frame is received
+that permits more streams than can be expressed by the stream ID
+(i.e. greater than 2^60 - 1), the connection MUST be immediately closed with a

Yeah, I think that is better.  Or "If a MAX_STREAMS carries a value of 2^60 or greater (which implies a maximum stream ID that cannot be expressed in the protocol), then the connection MUST ..."

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2499#discussion_r262781169

v2.23.0 | Report a Bug | By Email