Re: [quicwg/base-drafts] Compatible version upgrade (#1901)

Kazuho Oku <notifications@github.com> Wed, 07 November 2018 08:28 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F27DD128CB7 for <quic-issues@ietfa.amsl.com>; Wed, 7 Nov 2018 00:28:54 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BcPCIgnFor_P for <quic-issues@ietfa.amsl.com>; Wed, 7 Nov 2018 00:28:53 -0800 (PST)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E7107128B14 for <quic-issues@ietf.org>; Wed, 7 Nov 2018 00:28:52 -0800 (PST)
Date: Wed, 07 Nov 2018 00:28:51 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1541579331; bh=ummLoreFDlr/7RI2Q6bHVi5z2sE++/dOU7V8Vc/gAfU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=QgOm2s1RJ72tzkZQsqCwjbQo32LU1qmZE8sggPshBxIehODbMmh+ObMCa0k5jbWTO rHG0FY9yFzMFRmmkFCbsh7GpyYHXX4cJm0Lze5/xK8/FIStXxMTrz9P3Cn+S/k1SwD JLQYgGVBi9pEb2ThNb1FUCGDeq8Mo7NOWlUa9o0Y=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab7b7c022f0e310b20476947ca51dcc28be7b1cc3e92cf0000000117fa644392a169ce1640b1a8@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1901/c436543850@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1901@github.com>
References: <quicwg/base-drafts/pull/1901@github.com>
Subject: Re: [quicwg/base-drafts] Compatible version upgrade (#1901)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5be2a2436f4c2_27a53f8f5e2d45c484438e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/7ugGV5ifT66LrysxTcMoEEW1vIk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Nov 2018 08:28:55 -0000

@martinduke:
> In Bangkok @kazuho short-circuited my objection at the mic by pointing out that the min DCID length might be different in other versions.
> 
> Upon further review, this requires a minor tweak to the spec: the client MUST select an initial DCID long enough for every version it supports. This implies that the maximum initial DCID length is invariant across versions, but I can't see a use case where we would drop that below 18.

FWIW, let me note that in the current design, it is not impossible for a server cluster with mixed supported versions to respond in a way that does not cause the clients to see "downgrade attacks", even in case the resent Initial lands on a different server within the cluster.

This is how you would do in case you are upgrading a cluster to support v2:

1. Some of the servers start accepting v2, but continues to claim support only for v1 in the VN packets.
2. During this period, when the server receives a v1 Initial, it responds with `supported_versions` that only contains v1. When the server receives a v2 Initial, it responds with `supported_versions` that contains both v1 and v2.
3. After all servers start accepting v2, they start sending v2 in the VN packet and also in `supported_versions`.

The difference from what you would do when we have "compatible version upgrade" is step 2; we need to send different `supported_versions` based on the version number of the client's Initial. This looks strange, but I think it would work.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1901#issuecomment-436543850