Re: [quicwg/base-drafts] Compatible version upgrade (#1901)

Kazuho Oku <notifications@github.com> Fri, 26 October 2018 02:53 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A4DD3130DC6 for <quic-issues@ietfa.amsl.com>; Thu, 25 Oct 2018 19:53:33 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hauPDTcRpU7R for <quic-issues@ietfa.amsl.com>; Thu, 25 Oct 2018 19:53:32 -0700 (PDT)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4B4FD1294D7 for <quic-issues@ietf.org>; Thu, 25 Oct 2018 19:53:32 -0700 (PDT)
Date: Thu, 25 Oct 2018 19:53:31 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1540522411; bh=cdAIDY4qGcSv5fyGRBXW7sMnAXU523OCckT9nCQ8tfo=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=mO4ApzbzZVExSHvV10Ud8EqMYIgCQcXEm9Zqd72dWoyAA9PWAfkKAptv8cdaP1EWf 75Nil6xwpi/frK4tdEqyKtX8uissDmcdeeO/VAyI6ZPWi2U2p32+LwiQciXa4t4E1M WpwZ8Q2beaoh3rGwEvLZ/aTx0EDorJ38vziVGjj8=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab0d19e9ae6093a868d3e0c006c779296beca8544d92cf0000000117ea43ab92a169ce1640b1a8@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1901/review/168656203@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1901@github.com>
References: <quicwg/base-drafts/pull/1901@github.com>
Subject: Re: [quicwg/base-drafts] Compatible version upgrade (#1901)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bd281ab80868_5da63fc041ad45bc8021af"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/RZixKpxCGkN4zCS1EpCCGKhAI0o>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 26 Oct 2018 02:53:34 -0000

kazuho commented on this pull request.



> +
+Client and server exchange information about versions along with transport
+parameters in order to protect against version downgrade attacks (see
+{{version-validation}}).
+
+The `supported_versions` field is a list of the versions the client supports.
+This field enables upgrade to compatible versions (see {{version-upgrade}}).  A
+client MAY omit versions from this list if they appear in the
+`unsupported_versions` field.
+
+The `unsupported_versions` field is a list of the versions the client supports,
+but which the client believes that the server does not support.  This list MUST
+be empty unless the client has received and processed a Version Negotiation
+packet.  A client MUST NOT omit a version that it supports from
+`unsupported_versions`, unless the Version Negotiation packet it processed
+listed that version.

I wonder if this _unless_ clause contradicts with the following sentence added above: _Though different versions might convey information about versions differently, a client MUST NOT change the set of versions it claims to support._

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1901#pullrequestreview-168656203