Re: [quicwg/base-drafts] Updated ICMP PMTU section (#1412)

Igor Lubashev <notifications@github.com> Tue, 26 June 2018 04:25 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8159A130F61 for <quic-issues@ietfa.amsl.com>; Mon, 25 Jun 2018 21:25:27 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 38Esjg78r7ip for <quic-issues@ietfa.amsl.com>; Mon, 25 Jun 2018 21:25:26 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F33471277BB for <quic-issues@ietf.org>; Mon, 25 Jun 2018 21:25:25 -0700 (PDT)
Date: Mon, 25 Jun 2018 21:25:24 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1529987125; bh=Vo+qsSJt8HyEYDIzdh2DdUtjV147e52kgwxv7ad84po=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=W3gQ4gxnEEAajHU+aaoi8Nm22mjilyf3Iizm86ec+rRHtZXlUmffaUZHQ67o8QLVz ezNKltN4XBkrCn1dc+oym+icglcrXFMkEv4v7iLUHG/Q97Jn89O6+zU4dbK1wKGsLN xLjV2bXBmtB9Ll4OaEQVM2YSYg5RkLJz2oUUn+E4=
From: Igor Lubashev <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab60a13f45b75820ada576ff3339c53806c02f774c92cf000000011749823492a169ce13a079ba@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1412/c400174137@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1412@github.com>
References: <quicwg/base-drafts/pull/1412@github.com>
Subject: Re: [quicwg/base-drafts] Updated ICMP PMTU section (#1412)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b31c034f2449_1c2323f890d8e6f7c6735a"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: igorlord
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/7yloivvpKMhOMNev3HoM6l6HJcc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Jun 2018 04:25:28 -0000

I've made updates per feedback received.  There are two points of discussion left (that I know of):

1. This is promoting ICMP processing to a SHOULD.  I think this is a correct thing to do, since PLPMTUD claims itself to be an extension of ICMP-based PMTUD process.  Of course, implementations w/o access to ICMP would not be able to implement this SHOULD, but this is ok albeit unfortunate -- the very definition of a SHOULD (skipping on MAY is not "unfortunate").

2. I am using a mostly made up number (1392) as "conservative enough to be believed w/o on-path proof".  It was a compromise between "small enough for most Internet tunnels" and "not that small that someone would go into troubles of maliciously reducing PMTU of the victim to that number".  This may need a discussion.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1412#issuecomment-400174137