Re: [quicwg/base-drafts] HTTP SETTINGS: define setting content encoding (#1556)

afrind <notifications@github.com> Mon, 16 July 2018 20:50 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B4612130E2C for <quic-issues@ietfa.amsl.com>; Mon, 16 Jul 2018 13:50:42 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.009
X-Spam-Level:
X-Spam-Status: No, score=-3.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id i3bxjBZY_47F for <quic-issues@ietfa.amsl.com>; Mon, 16 Jul 2018 13:50:40 -0700 (PDT)
Received: from o1.sgmail.github.com (o1.sgmail.github.com [192.254.114.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 946D4130DD0 for <quic-issues@ietf.org>; Mon, 16 Jul 2018 13:50:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=seAid4iKPjRFwqmFg+Kqy09TY0w=; b=skWm2dRN8rR3Rwed Cb5KUdeKu0MKTIT13/Fyy3W+gymLrunscT18ZsANCruMuDTjYG+2PIEcZoac9XTc F+9SZ5S64UeZC/vj6o8fm/iCdA/dyofDDBUPkrog33BmcQkle0xTcE/N8ooNnzdp GUgdW47xvKq4cPHUSRNwCAE799E=
Received: by filter0883p1las1.sendgrid.net with SMTP id filter0883p1las1-12436-5B4D051F-13 2018-07-16 20:50:39.371142872 +0000 UTC m=+346294.220326675
Received: from github-lowworker-e8fa9ff.cp1-iad.github.net (unknown [192.30.252.43]) by ismtpd0002p1iad1.sendgrid.net (SG) with ESMTP id iz3FEWi2RfWObXtYhpJIuw for <quic-issues@ietf.org>; Mon, 16 Jul 2018 20:50:39.242 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-e8fa9ff.cp1-iad.github.net (Postfix) with ESMTP id 26B33420374 for <quic-issues@ietf.org>; Mon, 16 Jul 2018 13:50:39 -0700 (PDT)
Date: Mon, 16 Jul 2018 20:50:39 +0000
From: afrind <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abaedce8843912225d88ea16db4ba6aed14a2a1a2892cf000000011764c71f92a169ce14546a14@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1556/405377723@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1556@github.com>
References: <quicwg/base-drafts/issues/1556@github.com>
Subject: Re: [quicwg/base-drafts] HTTP SETTINGS: define setting content encoding (#1556)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b4d051f22f3f_7a3e2aacc6be8f503441e6"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: afrind
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0H2I/gdaBE4AufqUdT0H2cnHiFYrL7A7gRd+ FtnAdhYl4ucCxZkR06yvXQbe7TZr3BFjJ2Kcf0z0K42k0B4uT9xAO3v6Qs4Frz2qlCPvmHppTqje67 9l9ttE7j6mEN5p7z911q1ynIr8HrdDe0MMp5XvqSfqgC3LsEGPeg7IHMHA==
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/9u0My6U2-TVa94sRkliVm2Z2TYE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Jul 2018 20:50:43 -0000

> 4.2.6.1.  Integer encoding
>
>   Settings which are integers use the QUIC variable-length integer encoding.

So I don't think there's anything ambiguous in the current draft.  It is strange however that there is both a variable-length integer specifying the length of the integer setting AND the setting itself is a variable-length integer, so its length is self-describing and redundant.  

We could instead define settings that are integers use all of the `Contents` octets to specify the integer and take the length exclusively from the `Length` field of the parameter.  This would save a byte on the wire here and there (eg a parameter with value 100 currently requires 3 bytes to encode), and possibly make things a little less confusing, at the cost of having yet another way to encode integers.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1556#issuecomment-405377723