Re: [quicwg/base-drafts] HTTP SETTINGS: define setting content encoding (#1556)

Mike Bishop <notifications@github.com> Fri, 27 July 2018 19:52 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 82147130DF5 for <quic-issues@ietfa.amsl.com>; Fri, 27 Jul 2018 12:52:30 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JzU3qxzvngUr for <quic-issues@ietfa.amsl.com>; Fri, 27 Jul 2018 12:52:28 -0700 (PDT)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7931B130DD1 for <quic-issues@ietf.org>; Fri, 27 Jul 2018 12:52:28 -0700 (PDT)
Date: Fri, 27 Jul 2018 12:52:27 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1532721147; bh=nEWPxU3aIkVMvARBeOW++Uv5iP3FJ5BeJbPK4oC0egg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=hnAZWAGuVVa2VfTapxJtfzA82xtlgHCmOHdXXtLXcGKhBmg1D7aNWcp5/+ewfWlpf fCuMkJOQKubgtcuzhg8JrMLjt+6xcCv97+8oowBUY7MPtcoMjyfDQm3wk58a70buAT rv6Hc6/zsI8PkIcSJEOE1lOVGpA0GDuatBXz7yXc=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4aba6ab08c8620eecdbbeabb5d1748ee034b17460cc92cf00000001177339fb92a169ce14546a14@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1556/408522332@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1556@github.com>
References: <quicwg/base-drafts/issues/1556@github.com>
Subject: Re: [quicwg/base-drafts] HTTP SETTINGS: define setting content encoding (#1556)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b5b77fb65397_77d63f9eaa4be6181097cd"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/YAM6RReUmkkTd-pOtzczG1Evc3Y>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Jul 2018 19:52:31 -0000

@afrind, that's an interesting point.  Could you split that out into a separate issue?

The current boolean encoding is intended to save bytes in the case of turning something on/off and not needing to convey any other data (e.g. "I support extension Foo").  If you don't send anything, the default case, it's false; it takes the minimum possible length to send true.  Because HQ doesn't allow modifying settings after the initial setup, we don't need an affordance for turning something that was true back to false.  In HTTP/2, you got 32 bytes regardless of how much or little you needed to convey, so settings of this sort use 0/1 and make other value invalid, or they use 0/non-zero.  However, most extensions to HTTP/2 so far have defined non-critical frames that didn't need a setting.

I'm not opposed to saying the payload of the integer settings isn't a varint, but it seems like that introduces additional complexity to deal with oddly-sized integers.  Is that a noticeably different level of complexity from having to check that the varint is the size claimed by the setting?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1556#issuecomment-408522332