IETF Logo Mail Archive

Re: [quicwg/base-drafts] State machine for CC (#4055)

Jana Iyengar <notifications@github.com> Fri, 04 September 2020 20:16 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E91803A0FA5 for <quic-issues@ietfa.amsl.com>; Fri, 4 Sep 2020 13:16:27 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.483
X-Spam-Level:
X-Spam-Status: No, score=-1.483 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cGYq86Ftk8Li for <quic-issues@ietfa.amsl.com>; Fri, 4 Sep 2020 13:16:26 -0700 (PDT)
Received: from out-18.smtp.github.com (out-18.smtp.github.com [192.30.252.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B16643A0D25 for <quic-issues@ietf.org>; Fri, 4 Sep 2020 13:16:26 -0700 (PDT)
Received: from github-lowworker-3a0df0f.ac4-iad.github.net (github-lowworker-3a0df0f.ac4-iad.github.net [10.52.25.92]) by smtp.github.com (Postfix) with ESMTP id E264534092F for <quic-issues@ietf.org>; Fri, 4 Sep 2020 13:16:25 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1599250585; bh=9XsEpDveZN8tcy5btDM6Q5mzVu8mcjoBPMLj61XNFsQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=QrVHivH/OnSdK9WMcmOPhno3zAPPTTlkErNR8CJ4z9iUHn+mNwvnB+IFq+Ks/05eV QaUa9JutYPIu6+AWdBkJjPDQeYSjKstlcW8elCtsj5AW3ukGA6VVUposUmyDe82aLk 62KEBSUg1HERh+RKLXw1966CcObKgLmMBQrkNtQw=
Date: Fri, 04 Sep 2020 13:16:25 -0700
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK76DL2HXUVBD7G4YP55L2AZTEVBNHHCRYSBB4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4055/review/482918336@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4055@github.com>
References: <quicwg/base-drafts/pull/4055@github.com>
Subject: Re: [quicwg/base-drafts] State machine for CC (#4055)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f52a099d23fc_768c19f09852e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Br6TIpa9qWUmxJhyTtG0q-fNZm0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Sep 2020 20:16:28 -0000

@janaiyengar commented on this pull request.



>  
 The recovery period aims to limit congestion window reduction to once per round
-trip. Therefore during recovery, the congestion window remains unchanged
-irrespective of new losses or increases in the ECN-CE counter.
+trip. Therefore during a recovery period, the congestion window does not change
+in response to new losses or increases in the ECN-CE count.
+
+A recovery period ends and the sender enters congestion avoidance when a packet
+sent during the recovery period is acknowledged. This is slightly different
+from TCP's definition of recovery, which ends when the lost segment that
+started recovery is acknowledged ({{?RFC5681}}).
+
+### Congestion Avoidance
+
+A NewReno sender is in congestion avoidance any time the congestion window is

This is specific to NewReno, so I would leave this as it is.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4055#discussion_r483827188

v2.23.0 | Report a Bug | By Email