Re: [quicwg/base-drafts] State machine for CC (#4055)

[Mike Bishop <[e-mail]>]

@MikeBishop commented on this pull request.



> +                 Start or         +------------+
+            persistent congestion |   Slow     |
+        (O)---------------------->|   Start    |
+                                  +------------+
+                                        |
+                                Loss or |
+                        ECN-CE increase |
+                                        v

```suggestion
            Start                 +------------+
             (O)----------------->|   Slow     |
       +------------------------->|   Start    |
       |                          +------------+
       | Persistent                     |
       | congestion             Loss or |
       |                ECN-CE increase |
       |                                v
```

It's probably worth calling persistent congestion out as a separate transition rather than a restart.  Though it's more complex than that, since I believe persistent congestion is also checked only on a loss event.

>  
-## Recovery Period {#recovery-period}
+A sender enters the recovery period when it detects the loss of a packet or the
+ECN-CE count reported by its peer increases. A sender that is already in a
+recovery period stays in it and does not re-enter it.

Switching between "the"/"a" here.

> -threshold is set to the new congestion window.  QUIC re-enters slow start
-any time the congestion window is less than the slow start threshold,
-which only occurs after persistent congestion is declared.
+~~~
+                 Start or         +------------+
+            persistent congestion |   Slow     |
+        (O)---------------------->|   Start    |
+                                  +------------+
+                                        |
+                                Loss or |
+                        ECN-CE increase |
+                                        v
+ +------------+     Loss or       +------------+
+ | Congestion |  ECN-CE increase  |  Recovery  |
+ | Avoidance  |------------------>|   Period   |
+ +------------+                   +------------+

Looks like that's been added.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4055#pullrequestreview-475534914