IETF Logo Mail Archive

Re: [quicwg/base-drafts] State machine for CC (#4055)

ianswett <notifications@github.com> Wed, 02 September 2020 14:11 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 345973A0774 for <quic-issues@ietfa.amsl.com>; Wed, 2 Sep 2020 07:11:34 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.483
X-Spam-Level:
X-Spam-Status: No, score=-1.483 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VWvrhVEDqKkT for <quic-issues@ietfa.amsl.com>; Wed, 2 Sep 2020 07:11:33 -0700 (PDT)
Received: from out-25.smtp.github.com (out-25.smtp.github.com [192.30.252.208]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E6CD43A0766 for <quic-issues@ietf.org>; Wed, 2 Sep 2020 07:11:32 -0700 (PDT)
Received: from github-lowworker-5825cd4.ac4-iad.github.net (github-lowworker-5825cd4.ac4-iad.github.net [10.52.22.68]) by smtp.github.com (Postfix) with ESMTP id E864084005C for <quic-issues@ietf.org>; Wed, 2 Sep 2020 07:11:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1599055891; bh=b5AZUwDCmyM+AGTurj+eh4xeaZLimYWw3pK2zAVshGA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=quWZHMPnOuttc0ToIRPJVVQn2RDndarUun13Jz1zNfhhQsZEr+zpDsB2rftQPAzyD qhTTeH2Z8s7cOqoNOb0Eh+PVcgIHLQZb3IDSS4FI70SeMt7YBvJ75dnfAmIggh1XMj z2vXPimSp54yITp5PjdGV3uU9rGKdD60q5Vnstn0=
Date: Wed, 02 Sep 2020 07:11:31 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK62BRWNMREPMJC4JLF5LOERHEVBNHHCRYSBB4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4055/review/480853123@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4055@github.com>
References: <quicwg/base-drafts/pull/4055@github.com>
Subject: Re: [quicwg/base-drafts] State machine for CC (#4055)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f4fa813d8ef6_63ed19646428e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/1TvNcGcq4yztMWu8I9QG5kURmbA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Sep 2020 14:11:34 -0000

@ianswett approved this pull request.

Looks good, but it's a bit change, so I'd like @janaiyengar review as well.

>  
-Implementations MAY set the congestion window immediately on entering a recovery
-period or use other mechanisms, such as Proportional Rate Reduction
-({{?PRR=RFC6937}}), to reduce it more gradually. If the congestion window is
-reduced immediately, a single packet can be sent prior to reduction. This speeds
-up loss recovery if the data in the lost packet is retransmitted and is similar
-to TCP as described in Section 5 of {{?RFC6675}}.
+Implementations MAY set the congestion window immediately upon entering a

```suggestion
Implementations MAY reduce the congestion window immediately upon entering a
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4055#pullrequestreview-480853123

v2.23.0 | Report a Bug | By Email