Re: [quicwg/base-drafts] STOP_SENDING opens streams (#2013)

Marten Seemann <notifications@github.com> Sat, 17 November 2018 01:40 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 09D8A126CB6 for <quic-issues@ietfa.amsl.com>; Fri, 16 Nov 2018 17:40:09 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OjGVCBfGdS7c for <quic-issues@ietfa.amsl.com>; Fri, 16 Nov 2018 17:40:07 -0800 (PST)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DED59128B14 for <quic-issues@ietf.org>; Fri, 16 Nov 2018 17:40:06 -0800 (PST)
Date: Fri, 16 Nov 2018 17:40:04 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1542418804; bh=2Vhsowf8b2ivMaWjbZXjIkboQf9wpUrPmUJkx9FDf6g=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=v4s72qg8cA8lbdB+UTbgPMVF7EPf9CnR9feYGn2sZoeuBeHP82wfaXNhYtL9ucmFk 42eIceAdBn81DGskBbM5YigbQ9DAVPSfRyK8UN8QW9a7tL3Lw1ecrp+vVVNXAWKkBd MbL4x5FE26g3IGjKlowfmfpB+zBAbtcl0LYWfBxw=
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abfaf956ab2acd201c0df5e79646965a47dac687b692cf000000011807337492a169ce16bb487b@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2013/review/176034256@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2013@github.com>
References: <quicwg/base-drafts/pull/2013@github.com>
Subject: Re: [quicwg/base-drafts] STOP_SENDING opens streams (#2013)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bef717476681_6a573fb92cad45c4765c1"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/F6GmTAxdm4bwLz13tGF68Mi_M3E>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 17 Nov 2018 01:40:09 -0000

marten-seemann approved this pull request.



> @@ -4276,12 +4280,12 @@ An endpoint uses a STOP_SENDING frame (type=0x05) to communicate that incoming
 data is being discarded on receipt at application request.  This signals a peer
 to abruptly terminate transmission on a stream.
 
-Receipt of a STOP_SENDING frame is only valid for a send stream that exists and
-is not in the "Ready" state (see {{stream-send-states}}).  Receiving a
-STOP_SENDING frame for a send stream that is "Ready" or non-existent MUST be
-treated as a connection error of type PROTOCOL_VIOLATION.  An endpoint that
-receives a STOP_SENDING frame for a receive-only stream MUST terminate the
-connection with error PROTOCOL_VIOLATION.
+Receipt of a STOP_SENDING frame is invalid for a locally-initiated stream which
+does not exist or is in the "Ready" state (see {{stream-send-states}}).

"does not exist" sounds a bit weird. In my implementation, when a stream is fully closed, I delete it from my map of streams at some point. At that moment, it does not exist any more, but receipt of a (delayed) STOP_SENDING is still a valid thing.

Maybe we can say "has not yet been created".

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2013#pullrequestreview-176034256