IETF Logo Mail Archive

Re: [quicwg/base-drafts] STOP_SENDING opens streams (#2013)

MikkelFJ <notifications@github.com> Thu, 15 November 2018 22:52 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0EF8212D4E6 for <quic-issues@ietfa.amsl.com>; Thu, 15 Nov 2018 14:52:43 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AKd-tcoGHkBE for <quic-issues@ietfa.amsl.com>; Thu, 15 Nov 2018 14:52:41 -0800 (PST)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4D5C2129619 for <quic-issues@ietf.org>; Thu, 15 Nov 2018 14:52:41 -0800 (PST)
Date: Thu, 15 Nov 2018 14:52:40 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1542322360; bh=rAGbfVpd40BBfb4p5BoM0AzO7XM+vbp0kpTK3sPH3/U=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=uSegT5TCtkRIqBNPh2mg2ON0D60w+lXtviBzDZVlbgzqHfzNq3SxXgL01I/3vtlbk XQLtrv8L4JunUZutIA5kjmVhqFXbtBhhEpzb4QRjl52ePfSURtB3jIeygEZTuNngFq i53pEUbVMtjAOTszIvKp4OayV2IDywlxmwr2Esk4=
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab5da88b84d86e20d7ca9b861b6af71657da027a9892cf000000011805bab892a169ce16bb487b@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2013/review/175594119@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2013@github.com>
References: <quicwg/base-drafts/pull/2013@github.com>
Subject: Re: [quicwg/base-drafts] STOP_SENDING opens streams (#2013)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bedf8b848ed5_2ee33f8eca6d45b4166039"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/P-2Y-2-kouxdAfFVWL_0ZTvyN_M>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Nov 2018 22:52:43 -0000

mikkelfj commented on this pull request.



> @@ -4276,12 +4280,12 @@ An endpoint uses a STOP_SENDING frame (type=0x05) to communicate that incoming
 data is being discarded on receipt at application request.  This signals a peer
 to abruptly terminate transmission on a stream.
 
-Receipt of a STOP_SENDING frame is only valid for a send stream that exists and
-is not in the "Ready" state (see {{stream-send-states}}).  Receiving a
-STOP_SENDING frame for a send stream that is "Ready" or non-existent MUST be
-treated as a connection error of type PROTOCOL_VIOLATION.  An endpoint that
-receives a STOP_SENDING frame for a receive-only stream MUST terminate the
-connection with error PROTOCOL_VIOLATION.
+Receipt of a STOP_SENDING frame is invalid for a locally-initiated stream which
+does not exist or is in the "Ready" state (see {{stream-send-states}}).
+Receiving a STOP_SENDING frame for a locally-initiated send stream that is
+"Ready" or non-existent MUST be treated as a connection error of type
+PROTOCOL_VIOLATION.  An endpoint that receives a STOP_SENDING frame for a
+receive-only stream MUST terminate the connection with error PROTOCOL_VIOLATION.
 

I don't think this handles STOP_SENDING sent on an implicitly opened stream.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2013#pullrequestreview-175594119

v2.23.0 | Report a Bug | By Email