Re: [quicwg/base-drafts] STOP_SENDING opens streams (#2013)

Ryan Hamilton <notifications@github.com> Fri, 16 November 2018 01:44 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 84C19130DE6 for <quic-issues@ietfa.amsl.com>; Thu, 15 Nov 2018 17:44:24 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Fbd2jyxuW73N for <quic-issues@ietfa.amsl.com>; Thu, 15 Nov 2018 17:44:23 -0800 (PST)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id ED4DF123FFD for <quic-issues@ietf.org>; Thu, 15 Nov 2018 17:44:22 -0800 (PST)
Date: Thu, 15 Nov 2018 17:44:21 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1542332661; bh=Pbi3pae51AEW+GXJ0w32Jf7YxB4K6AMIP8cSpp5jVq8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=ej4Pecq+00s01GjPuVRHSH4hwEpaj33m8a1hKMmBRRDA5iqjBBhGQEVjTV+cFjiSg gk5y8vZ4e56hU3Bzx3bWskeCcZNub/sHM98uFdb/ZwjFyTARcyDYJInhIpfK+kV4ij D8rLlxXxC3AHc81WGmTqNmoA3UzeNIJUnmmVhnMw=
From: Ryan Hamilton <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab08012695349492f40bea4720be7fecb447976e0e92cf000000011805e2f592a169ce16bb487b@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2013/review/175630826@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2013@github.com>
References: <quicwg/base-drafts/pull/2013@github.com>
Subject: Re: [quicwg/base-drafts] STOP_SENDING opens streams (#2013)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bee20f5bf719_5a773ff3a08d45b826825c"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: RyanAtGoogle
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/jPVVMoa-i4WsXH9ZdrpIHs6-KO0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Nov 2018 01:44:24 -0000

RyanAtGoogle commented on this pull request.

This looks great to me! I agree with your unease about "receiving a frame for the sending part opens the receiving part, which opens the sending part, so the frame on the sending part is now valid to have received." But as you say, working with the existing text, that does seem fine. In any case, this feels like a definitely improvement to the status quo.

Thanks!



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2013#pullrequestreview-175630826