IETF Logo Mail Archive

Re: [quicwg/base-drafts] Add some MUSTs to congestion control (#3978)

ianswett <notifications@github.com> Sat, 29 August 2020 13:23 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4A2693A08E5 for <quic-issues@ietfa.amsl.com>; Sat, 29 Aug 2020 06:23:02 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.555
X-Spam-Level:
X-Spam-Status: No, score=-1.555 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qUdNQpBHDCR5 for <quic-issues@ietfa.amsl.com>; Sat, 29 Aug 2020 06:23:00 -0700 (PDT)
Received: from out-27.smtp.github.com (out-27.smtp.github.com [192.30.252.210]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B60D13A08F9 for <quic-issues@ietf.org>; Sat, 29 Aug 2020 06:23:00 -0700 (PDT)
Received: from github-lowworker-39ac79b.ac4-iad.github.net (github-lowworker-39ac79b.ac4-iad.github.net [10.52.18.15]) by smtp.github.com (Postfix) with ESMTP id 8B83B900204 for <quic-issues@ietf.org>; Sat, 29 Aug 2020 06:22:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1598707379; bh=25aXBju1frbWzJqvbFbErPUByXEt0xRklUwbAfbvgVo=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=1JUFeDZ/qFg06L+jvrA5YBZn5C7SKn/V93sqyLlpu73xl/9qhcR5oIAdV56HXMxfs GQ97PPwSnyIyHhB4lbn3kPGttGjX/ImjFkJmuxMQu62LDszrVQRSULhjalciSUR1f0 F66BwBHkmd4ATJanBo5Glz+0XvlUoqmADZL/JRAs=
Date: Sat, 29 Aug 2020 06:22:59 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7IHLGXUORW3QDDQ655KY33HEVBNHHCQBGZIM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3978/review/478127709@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3978@github.com>
References: <quicwg/base-drafts/pull/3978@github.com>
Subject: Re: [quicwg/base-drafts] Add some MUSTs to congestion control (#3978)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f4a56b37ae43_4efb19641131967"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/GBDNSaUoAPFqg58iGFupnomcggE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Aug 2020 13:23:02 -0000

@ianswett commented on this pull request.

Thanks for updating this while I was gone, looks like a good resolution.

>  
 The recovery period aims to limit congestion window reduction to once per round
 trip. Therefore during recovery, the congestion window remains unchanged
 irrespective of new losses or increases in the ECN-CE counter.
 
-When entering recovery, a single packet MAY be sent even if bytes in flight
-now exceeds the recently reduced congestion window.  This speeds up loss
+When entering a recovery period, a single packet MAY be sent even if bytes in

I find this paragraph a bit odd given the adjusted text about when to reduce CWND, but I guess it's fine.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3978#pullrequestreview-478127709

v2.23.0 | Report a Bug | By Email