Re: [quicwg/base-drafts] Add some MUSTs to congestion control (#3978)

mirjak <notifications@github.com> Wed, 26 August 2020 08:39 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A34933A104B for <quic-issues@ietfa.amsl.com>; Wed, 26 Aug 2020 01:39:29 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.483
X-Spam-Level:
X-Spam-Status: No, score=-1.483 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RZUsKa50dRmV for <quic-issues@ietfa.amsl.com>; Wed, 26 Aug 2020 01:39:28 -0700 (PDT)
Received: from out-18.smtp.github.com (out-18.smtp.github.com [192.30.252.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5D5533A1032 for <quic-issues@ietf.org>; Wed, 26 Aug 2020 01:39:28 -0700 (PDT)
Received: from github-lowworker-d31a065.va3-iad.github.net (github-lowworker-d31a065.va3-iad.github.net [10.48.17.70]) by smtp.github.com (Postfix) with ESMTP id 8546234019A for <quic-issues@ietf.org>; Wed, 26 Aug 2020 01:39:27 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1598431167; bh=aSzAp2OvAvRalg8liceAqOdYuvecoiZgjxRPMC8dpB8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=iYArtnCeifm0pGGYds1OBN8fMCXfPKX2FMosV87/BmgDGLvPScgqnhgPeqWmoBcmU 7kqNydaER/QpIo59q7IEtJrDEG5k/JlMKstx71MqwISrQE4Qg25m0tbMGgsQACurH7 zh45fmVI+intJwk07jLMtgeBTbwrfYC6QQMHBL9c=
Date: Wed, 26 Aug 2020 01:39:27 -0700
From: mirjak <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4UI5HYBO7KPWNUVGV5KIAL7EVBNHHCQBGZIM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3978/review/475274428@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3978@github.com>
References: <quicwg/base-drafts/pull/3978@github.com>
Subject: Re: [quicwg/base-drafts] Add some MUSTs to congestion control (#3978)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f461fbf74d46_3465196416237"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mirjak
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/IKp1G1ZqHi0MBagQ5QzciWzXSqM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Aug 2020 08:39:30 -0000

@mirjak commented on this pull request.



> -during the recovery period is acknowledged.  This is slightly different from
-TCP's definition of recovery, which ends when the lost packet that started
-recovery is acknowledged.
+A NewReno sender enters the recovery period when it detects loss or an ECN-CE
+mark is received. A recovery period ends when a packet sent during the recovery
+period is acknowledged.
+
+A sender that is already in a recovery period stays in it and does not re-enter
+it.
+
+On entering recovery, a sender MUST do the following:
+
+* set the slow start threshold to half the value of the congestion window at the
+  moment that loss is detected, and
+
+* set the congestion window to the new value of the slow start

This still say that you have to set the cwnd to ssthresh when entering recovery. Saying that you have to do this when entering recovery and then saying that you may do it it later seems confusing.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3978#pullrequestreview-475274428