Re: [quicwg/base-drafts] Single Stream of Bytes for CRYPTO Frames (#1592)

Marten Seemann <notifications@github.com> Fri, 20 July 2018 19:26 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EEBE7130DFC for <quic-issues@ietfa.amsl.com>; Fri, 20 Jul 2018 12:26:10 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id m-fSyjXgEbS9 for <quic-issues@ietfa.amsl.com>; Fri, 20 Jul 2018 12:26:08 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 67E5A1292F1 for <quic-issues@ietf.org>; Fri, 20 Jul 2018 12:26:08 -0700 (PDT)
Date: Fri, 20 Jul 2018 12:26:07 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1532114767; bh=toH1o1sDpd0sbByRX5pbCzfq1m5CEC2mGi7+lBhT+lo=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=hReMJv5dJDVKbODwqhQla6KDO4Z3FrDhEXcjiKr36f/5qX6E5NAtSId0NxYvRDLfx +1U5Sb/vHgnvM3GRgOqfw38vqXvqDvEVYQEOOwd0lnc+p07pzo83a8+DFvYoHT2KOc Ehc1CcT+fwyzcIVL2HEpP32XvxHe8EA9QcSD15Sk=
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab12a02b8d318a32fbc53291c9e1cfe02cd2425b2092cf000000011769f94f92a169ce1474a4c7@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1592/406703559@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1592@github.com>
References: <quicwg/base-drafts/issues/1592@github.com>
Subject: Re: [quicwg/base-drafts] Single Stream of Bytes for CRYPTO Frames (#1592)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b52374f91c37_42d13f9be96be6201092e6"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/MvaIJ26P_nB-bFjOLn51yfkniiw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Jul 2018 19:26:11 -0000

IMHO, being able to reuse the existing stream code (including STREAM frame reassembly etc.) is the one of most important advantage of this change. Special-casing stream 0 to work with changing encryption levels required a significant amount of additional code.
I’m not worried about the overhead of this at all, after all, it’s just 4 streams, and you can remove them after the handshake completes (some of them even earlier, if you want to take optimizations to the extreme). 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1592#issuecomment-406703559