IETF Logo Mail Archive

Re: [quicwg/base-drafts] Single Stream of Bytes for CRYPTO Frames (#1592)

ianswett <notifications@github.com> Fri, 20 July 2018 19:06 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6EB33130EEE for <quic-issues@ietfa.amsl.com>; Fri, 20 Jul 2018 12:06:50 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id v9N_wLL-Ivnu for <quic-issues@ietfa.amsl.com>; Fri, 20 Jul 2018 12:06:48 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3BAB0130F6A for <quic-issues@ietf.org>; Fri, 20 Jul 2018 12:06:47 -0700 (PDT)
Date: Fri, 20 Jul 2018 12:06:46 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1532113606; bh=lywxYNxw3KDpJzjS2GVo3AH3lFIqA9nwDi5Ot01u1Ws=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=iCA/dJlDKn7SHbnOm/iF1/TR5t6i+PvjxvDdJr5tBFmro0lLgzLvmpLR+CKBkFOhb UxPtq3hteCa+tIk4qcxdgtfQ0pic4v3BCyklapH3HOBnMSOj9B2RY3RTokHh8jM72L KQyR6rgS721aa1Q889P6ZJkQupRJbrULqOaEhP0c=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab4e6b1973e7dff109e1589d881b7ec2ea4647f78992cf000000011769f4c692a169ce1474a4c7@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1592/406699167@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1592@github.com>
References: <quicwg/base-drafts/issues/1592@github.com>
Subject: Re: [quicwg/base-drafts] Single Stream of Bytes for CRYPTO Frames (#1592)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b5232c66c7db_67f33fb1102be6241109ee"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/D2egwwsAyjgLBpuSyguFe6lK46Q>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Jul 2018 19:06:51 -0000

I have the single stream approach implemented today, and it's ugly on the send side, because I need a very weird datastructure to determine what was sent at what encryption level and make sure there's no cross-encryption level bundling/etc.

With a stream per level, it's much clearer what's going on, and I can re-use most of the standard stream code.  I need to actually implement this, so maybe there are some issues I'm not anticipating, but I know the single stream approach is ugly.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1592#issuecomment-406699167

v2.23.0 | Report a Bug | By Email