Re: [quicwg/base-drafts] Make the ack-tracking examplary (#3979)

ianswett <notifications@github.com> Wed, 05 August 2020 02:37 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4986A3A1255 for <quic-issues@ietfa.amsl.com>; Tue, 4 Aug 2020 19:37:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.006
X-Spam-Level:
X-Spam-Status: No, score=-2.006 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_16=1.092, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id B6Cklw2SS6TM for <quic-issues@ietfa.amsl.com>; Tue, 4 Aug 2020 19:37:37 -0700 (PDT)
Received: from out-10.smtp.github.com (out-10.smtp.github.com [192.30.254.193]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3BBC53A1221 for <quic-issues@ietf.org>; Tue, 4 Aug 2020 19:37:37 -0700 (PDT)
Received: from github-lowworker-ca235ff.ash1-iad.github.net (github-lowworker-ca235ff.ash1-iad.github.net [10.56.110.15]) by smtp.github.com (Postfix) with ESMTP id 7A5E558009E for <quic-issues@ietf.org>; Tue, 4 Aug 2020 19:37:36 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1596595056; bh=3lLId68KkdjAfi1pf/fgLeJQ4G7/BA95iLzIAkxG9pI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Y8Y2TNGoELaERFPuAut0195J4sO8dnOktaAlCMXmgLFKYrSGmhTOCQNXNzKdpZB0E dgm3NnyDoymu7bAf8r0bKnsav6BaayFjsQvhzvatW2/dHEMYmtmvfRa0ZjPD4kyv90 lhrtq//TvdeKjguWIBQ5wPMRWBP9jvriFre770Ns=
Date: Tue, 04 Aug 2020 19:37:36 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK43ZKGMO2MJ67JTEAV5GX6HBEVBNHHCQD3SRM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3979/review/461299815@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3979@github.com>
References: <quicwg/base-drafts/pull/3979@github.com>
Subject: Re: [quicwg/base-drafts] Make the ack-tracking examplary (#3979)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f2a1b7034b80_6bef16f81513e5"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/NyLWP4Njp1fYgW9bO92QC89kBeI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Aug 2020 02:37:38 -0000

@ianswett commented on this pull request.



>  ack-eliciting packet has been received to include an ACK frame with outgoing
 frames.

Thanks, I think I'd rather not change it in this PR, but wanted to point out the awkwardness to reviewers.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3979#discussion_r465437358