IETF Logo Mail Archive

Re: [quicwg/base-drafts] Make the ack-tracking examplary (#3979)

ianswett <notifications@github.com> Mon, 03 August 2020 14:15 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D7B773A0AC1 for <quic-issues@ietfa.amsl.com>; Mon, 3 Aug 2020 07:15:05 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.501
X-Spam-Level:
X-Spam-Status: No, score=-0.501 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=0.7, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rblCQeMFv249 for <quic-issues@ietfa.amsl.com>; Mon, 3 Aug 2020 07:15:04 -0700 (PDT)
Received: from out-26.smtp.github.com (out-26.smtp.github.com [192.30.252.209]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 934AF3A0AB6 for <quic-issues@ietf.org>; Mon, 3 Aug 2020 07:15:04 -0700 (PDT)
Received: from github-lowworker-f144ac1.va3-iad.github.net (github-lowworker-f144ac1.va3-iad.github.net [10.48.16.59]) by smtp.github.com (Postfix) with ESMTP id 4A7FE5E0050 for <quic-issues@ietf.org>; Mon, 3 Aug 2020 07:15:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1596464103; bh=zfUMdLZi2jHxg1ij0FZdFC8HfECHtL/tTnRJbiOO7fU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=hcd0oG4XHUj/IqW87kScLZtlPEzF66quQF3OXvAsTYfZhD9gKNdADkCz0faFe/BEp jI1IG0XcHKc/UyfY+EgcVyswsvwdsZzLSLxpB65ciuc1UjR0tV56dfFLsk6cQptTfd Gp0zd7ZtFOUShFuKCFFgcTx7xrTzG6SEWBT5JBbQ=
Date: Mon, 03 Aug 2020 07:15:03 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYF5AIH7GFYZ6RQAJF5GP6OPEVBNHHCQD3SRM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3979/review/460062191@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3979@github.com>
References: <quicwg/base-drafts/pull/3979@github.com>
Subject: Re: [quicwg/base-drafts] Make the ack-tracking examplary (#3979)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f281be73af12_59b616f887877"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/xuyiGo3M0IHzTDfWLS-Kc5Sjk1I>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Aug 2020 14:15:06 -0000

@ianswett commented on this pull request.



>  ack-eliciting packet has been received to include an ACK frame with outgoing
 frames.

This is pre-existing, but this sentence is weird, particularly in the context of the "An endpoint MUST NOT send a non-ack-eliciting packet in response to a non-ack-eliciting packet..." above.

Is this supposed to be ", and endpoint waits until..." without the MAY?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3979#pullrequestreview-460062191

v2.23.0 | Report a Bug | By Email