Re: [quicwg/base-drafts] Make the ack-tracking examplary (#3979)
Martin Thomson <notifications@github.com> Tue, 04 August 2020 01:05 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 28D013A11CE for <quic-issues@ietfa.amsl.com>; Mon, 3 Aug 2020 18:05:13 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.497
X-Spam-Level:
X-Spam-Status: No, score=-0.497 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=0.7, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sTfMLYdvO7Ye for <quic-issues@ietfa.amsl.com>; Mon, 3 Aug 2020 18:05:12 -0700 (PDT)
Received: from out-19.smtp.github.com (out-19.smtp.github.com [192.30.252.202]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0273A3A11CD for <quic-issues@ietf.org>; Mon, 3 Aug 2020 18:05:11 -0700 (PDT)
Received: from github-lowworker-1ac52d7.ash1-iad.github.net (github-lowworker-1ac52d7.ash1-iad.github.net [10.56.25.52]) by smtp.github.com (Postfix) with ESMTP id 3767FE0DBA for <quic-issues@ietf.org>; Mon, 3 Aug 2020 18:05:10 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1596503110; bh=d0IMrrZAUBVenwiE8Ua9xELeucCiDM/vsNyDrsALnNs=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=TvgT8AchaB95wtQAglcLcuSRVKlMr9HrvV6HpQiRl8600faleXEuFep90BmkHPTMF YwkJwvCH0prdOeU8aaA7uxfBQbG1N7NW5g3Ao2eVOk2PvymYCfZKrmL9zUyZqjzmzY Cssc7LVxpUL1Hbx0DwsgoyHELO2QU6Pbatu1Voag=
Date: Mon, 03 Aug 2020 18:05:10 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK65BZVAK3DUMZJETGN5GSKUNEVBNHHCQD3SRM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3979/review/460429587@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3979@github.com>
References: <quicwg/base-drafts/pull/3979@github.com>
Subject: Re: [quicwg/base-drafts] Make the ack-tracking examplary (#3979)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f28b44626c1b_2b0216f8206654"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/mYe4xjFxsGJNCta9ysCRcOD_ctY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Aug 2020 01:05:13 -0000
@martinthomson approved this pull request. Thanks Ian. When you lay it out like this, it seems so obvious. I checked that we don't have citations for {{ack-tracking}}, so this works nicely. If you care about the "MAY", then we can fix that in another PR. > ack-eliciting packet has been received to include an ACK frame with outgoing frames. or "can". I don't think that there is any use for the MAY, but I don't think that the sentence is inherently *bad*. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/3979#pullrequestreview-460429587
- [quicwg/base-drafts] Make the ack-tracking exampl… ianswett
- Re: [quicwg/base-drafts] Make the ack-tracking ex… ianswett
- Re: [quicwg/base-drafts] Make the ack-tracking ex… ianswett
- Re: [quicwg/base-drafts] Make the ack-tracking ex… Martin Thomson
- Re: [quicwg/base-drafts] Make the ack-tracking ex… ianswett
- Re: [quicwg/base-drafts] Make the ack-tracking ex… Martin Thomson
- Re: [quicwg/base-drafts] Make the ack-tracking ex… Mike Bishop
- Re: [quicwg/base-drafts] Make the ack-tracking ex… ianswett
- Re: [quicwg/base-drafts] Make the ack-tracking ex… ianswett
- Re: [quicwg/base-drafts] Make the ack-tracking ex… ianswett
- Re: [quicwg/base-drafts] Make the ack-tracking ex… Martin Thomson
- Re: [quicwg/base-drafts] Make the ack-tracking ex… Martin Thomson
- Re: [quicwg/base-drafts] Make the ack-tracking ex… Jana Iyengar