Re: [quicwg/base-drafts] Improve Idle Timeout text (#3414)

ianswett <notifications@github.com> Thu, 12 March 2020 10:48 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1F38D3A0A85 for <quic-issues@ietfa.amsl.com>; Thu, 12 Mar 2020 03:48:28 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.554
X-Spam-Level:
X-Spam-Status: No, score=-1.554 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id adJ_Ky_VjQ9i for <quic-issues@ietfa.amsl.com>; Thu, 12 Mar 2020 03:48:27 -0700 (PDT)
Received: from out-24.smtp.github.com (out-24.smtp.github.com [192.30.252.207]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 47F663A09F9 for <quic-issues@ietf.org>; Thu, 12 Mar 2020 03:48:24 -0700 (PDT)
Date: Thu, 12 Mar 2020 03:48:22 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1584010102; bh=biB5JLA1Io7OWzvgQgEuTvBLULz99dvj+Yu2pQHdpQk=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=ldPAmotXKnX3JSsiOrSQK1xipTouqNWhX4+QXBHBms18Cb2vUc2c79gs6vbIzncI6 W8bQcXZXn7p43T+uMJJBk/AY9arPRzP1SPMoyqU3t7d6EodpwH65HeQJ0fQY5EnQpW z/k1bss6oCLd9e2DN//UY1tIHD9NaG4kINqRAZgM=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3HQW5TOJ6KSEJAO2F4OX2HNEVBNHHCCYK7ZU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3414/review/373449626@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3414@github.com>
References: <quicwg/base-drafts/pull/3414@github.com>
Subject: Re: [quicwg/base-drafts] Improve Idle Timeout text (#3414)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e6a13769b7d6_3e3d3f89166cd96c6180"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/OddWXnuRaqDz0-pSfB-VFskCRB8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Mar 2020 10:48:28 -0000

ianswett commented on this pull request.



>  
-Each endpoint advertises a max_idle_timeout, but the effective value
-at an endpoint is computed as the minimum of the two advertised values. By
-announcing a max_idle_timeout, an endpoint commits to initiating an immediate
+By announcing a max_idle_timeout, an endpoint commits to initiating an immediate
 close ({{immediate-close}}) if it abandons the connection prior to the effective

Thanks, I reverted this.  I think this was an unintentional change, but this has gone through so many iterations I'm not 100% sure.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3414#discussion_r391538079