Re: [quicwg/base-drafts] Scope of disable_active_migration (#3670)

[Martin Thomson <[e-mail]>]

@martinthomson commented on this pull request.

Seems fine.

> @@ -1229,10 +1229,11 @@ when a client's address changes.
   transport parameter to request that clients move connections to that dedicated
   address. Note that clients could choose not to use the preferred address.
 
-A server in a deployment that does not implement a solution to
-maintain connection continuity during connection migration
-SHOULD disallow migration using the disable_active_migration transport
-parameter.
+A server in a deployment that does not implement a solution to maintain
+connection continuity when the client address changes SHOULD indicate migration
+is not supported using the disable_active_migration transport parameter.  The
+disable_active_migration transport parameter does not prohibit connection
+migration after a client has acted on the preferred_address transport parameter.

```suggestion
migration after a client has acted on a preferred_address transport parameter.
```

> @@ -2150,15 +2151,15 @@ The design of QUIC relies on endpoints retaining a stable address for the
 duration of the handshake.  An endpoint MUST NOT initiate connection migration
 before the handshake is confirmed, as defined in section 4.1.2 of {{QUIC-TLS}}.
 
-An endpoint also MUST NOT send packets from a different local address, actively
-initiating migration, if the peer sent the disable_active_migration transport
-parameter during the handshake. An endpoint which has sent this transport
-parameter, but detects that a peer has nonetheless migrated to a different
-network MUST either drop the incoming packets on that path without generating a
-stateless reset or proceed with path validation and allow the peer to migrate.
-Generating a stateless reset or closing the connection would allow third parties
-in the network to cause connections to close by spoofing or otherwise
-manipulating observed traffic.
+If the peer sent the disable_active_migration transport parameter, an endpoint
+also MUST NOT send packets (including probing packets; see {{probing}}) from a
+different local address to the address the peer used during the handshake. An
+endpoint which has sent this transport parameter, but detects that a peer has

```suggestion
endpoint that has sent this transport parameter, but detects that a peer has
```

> @@ -2150,15 +2151,15 @@ The design of QUIC relies on endpoints retaining a stable address for the
 duration of the handshake.  An endpoint MUST NOT initiate connection migration
 before the handshake is confirmed, as defined in section 4.1.2 of {{QUIC-TLS}}.
 
-An endpoint also MUST NOT send packets from a different local address, actively
-initiating migration, if the peer sent the disable_active_migration transport
-parameter during the handshake. An endpoint which has sent this transport
-parameter, but detects that a peer has nonetheless migrated to a different
-network MUST either drop the incoming packets on that path without generating a
-stateless reset or proceed with path validation and allow the peer to migrate.
-Generating a stateless reset or closing the connection would allow third parties
-in the network to cause connections to close by spoofing or otherwise
-manipulating observed traffic.
+If the peer sent the disable_active_migration transport parameter, an endpoint
+also MUST NOT send packets (including probing packets; see {{probing}}) from a
+different local address to the address the peer used during the handshake. An
+endpoint which has sent this transport parameter, but detects that a peer has
+nonetheless migrated to a different network MUST either drop the incoming

```suggestion
nonetheless migrated to a different remote address MUST either drop the incoming
```

> +  the recipient MUST NOT send any packets to the address the peer used to
+  perform the handshake from a local address or port other than that used to
+  perform the handshake.  This parameter is a zero-length value.

I *might have a suggestion.
```suggestion
  an endpoint MUST NOT use a new local address when sending to the address
  that the peer used during the handshake.  This parameter is a zero-length value.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3670#pullrequestreview-415795983