IETF Logo Mail Archive

Re: [quicwg/base-drafts] frame type field of CONNECTION_CLOSE provides little value (#1989)

janaiyengar <notifications@github.com> Mon, 12 November 2018 11:18 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D78C6130DE6 for <quic-issues@ietfa.amsl.com>; Mon, 12 Nov 2018 03:18:36 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ogwGe38azdZk for <quic-issues@ietfa.amsl.com>; Mon, 12 Nov 2018 03:18:35 -0800 (PST)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5F997130DD7 for <quic-issues@ietf.org>; Mon, 12 Nov 2018 03:18:35 -0800 (PST)
Date: Mon, 12 Nov 2018 03:18:34 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1542021514; bh=vtMs9IFavEvzeLhj8ZVq/ea1HC/6GMNDBFwlnbpqWzQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=VT5+F0D68OJiwnTA5MwGDKvQALrvNIK2owvPA/s+waqJaHLlrKXtVOpT+ZUkpcyEI DyxG+jgJypbmYedGIRS8TMU+ZQBR9LYP1hdsvswJGeDOJ61xzL3ZG1wjMXehX9XuW2 yP+xBIWkl0ur30bSTrukk0og98GDs9QP1f77nSic=
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab2cfe630e0c0bbafcda6cbefe819aa6624a44d04492cf000000011801238a92a169ce169ea5c2@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1989/437844155@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1989@github.com>
References: <quicwg/base-drafts/issues/1989@github.com>
Subject: Re: [quicwg/base-drafts] frame type field of CONNECTION_CLOSE provides little value (#1989)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5be9618ab3a30_4f7e3fde8fcd45bc3730fa"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/SHVCf6tiJnD6Ine_biDC4G1eEBM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Nov 2018 11:18:37 -0000

I remember the discussion in Paris being quite pleasant and nice. What are you talking about, @marten-seemann?

The code above shows exactly how to populate the frame type field -- if known, populate with frame type, else use 0 (FramePadding).  The interpretation of 0 here is _special_ ... it implies that there's no frame type associated with this error.

I don't think this is terrible really. If you have a frame to associate with the error, use it, else use 0. It's unambiguous, even if not pretty.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1989#issuecomment-437844155

v2.23.0 | Report a Bug | By Email