Re: [quicwg/base-drafts] frame type field of CONNECTION_CLOSE provides little value (#1989)

Marten Seemann <notifications@github.com> Mon, 12 November 2018 06:26 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9801B1286E7 for <quic-issues@ietfa.amsl.com>; Sun, 11 Nov 2018 22:26:27 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9CawUhydCgi4 for <quic-issues@ietfa.amsl.com>; Sun, 11 Nov 2018 22:26:26 -0800 (PST)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 022D6124BAA for <quic-issues@ietf.org>; Sun, 11 Nov 2018 22:26:26 -0800 (PST)
Date: Sun, 11 Nov 2018 22:26:25 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1542003985; bh=JXUd7t8OVgZy6sGmOXcMeOUjaPje1A++O81h1LDR4sk=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=UziXiO2Eo75e0RYZQfPwYyLgcM67oxf8IVbUb1pGZy8nr2BTwNRtLYJdzkYtxjb4Q rt2R8RnHWzGhK72dGmfa9PCAw1xbvNiuZSSclpn1aOmKPGYTgW2Q6e9PmhDHYLkMZ1 Hie5e0IknkN1i6/6Ve0TAXU28KMH5Ir+ccqoYb+E=
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab31f9d0c0b6ebc9735aa3266b832cfa33f38f959392cf000000011800df1192a169ce169ea5c2@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1989/437770490@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1989@github.com>
References: <quicwg/base-drafts/issues/1989@github.com>
Subject: Re: [quicwg/base-drafts] frame type field of CONNECTION_CLOSE provides little value (#1989)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5be91d113311c_25b43fb9952d45b83668ae"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/vu-6HWOyfpzV-G1N2npU5iqMBKk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Nov 2018 06:26:27 -0000

I don't remember any discussion about error codes in Melbourne and Kista (and I can't find any in the minutes from there). If I remember correctly, the last we discussed error codes was in Paris, and it was a lengthy and rather unpleasant discussion. 
But it was long before we defined this strange frame format for the CONNECTION_CLOSE containing the frame type field. I don't have a strong opinion if we need one generic parsing error code, or an error code for every single frame type, but I feel that with the current solution we ended up with the worst of both worlds.

I'm sorry, but I have no idea what I'm supposed to see from the code snippet you posted.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1989#issuecomment-437770490