Re: [quicwg/base-drafts] frame type field of CONNECTION_CLOSE provides little value (#1989)

Martin Thomson <notifications@github.com> Mon, 12 November 2018 06:12 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 85622130DD6 for <quic-issues@ietfa.amsl.com>; Sun, 11 Nov 2018 22:12:38 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fE3W1K1D5R0Y for <quic-issues@ietfa.amsl.com>; Sun, 11 Nov 2018 22:12:37 -0800 (PST)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 08DC112D4E7 for <quic-issues@ietf.org>; Sun, 11 Nov 2018 22:12:36 -0800 (PST)
Date: Sun, 11 Nov 2018 22:12:35 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1542003155; bh=t8IcMvWi8YyQS2l7kIRFqrJvpfifrgY9j+6ZsLhGgPE=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=i7m4vY4IinVgl4wskEd0XbbGvvh3BeV2/xLZYWXvrsKT5pde6Bb9m6pBPr5mT27Kt kHkmFO6/yg5MQAvoO5fMuRvDsz3iNeBwSScVw1rirgce+nRDh9wCAm8d20flNkSgdJ ET2n004P8bq/+wWjXalKsEQabM2cRihj5bwhkszc=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abeaf955d93e08a9a9a5364bba3993c17009af255792cf000000011800dbd392a169ce169ea5c2@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1989/437768115@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1989@github.com>
References: <quicwg/base-drafts/issues/1989@github.com>
Subject: Re: [quicwg/base-drafts] frame type field of CONNECTION_CLOSE provides little value (#1989)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5be919d3de1bf_32af3f9aa98d45b85742e4"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/osvaM552jpldXt65foFu4_TVZyo>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Nov 2018 06:12:38 -0000

FWIW, I agree, but I'd rather not reopen the discussion.  What we have is the result of the discussion we had in either Melbourne or Kista about error handling.  Some people believed it important to have this level of reporting.  What I've seen is code like this:

```go
c.handling = f.type
switch f.type {
// dispatch to handlers
}
c.handling = FramePadding
// ...
func (c *Connection) error(qe QuicError) error {
  c.sendFrame(&ConnectionClose{c.handling, qe})
}
```


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1989#issuecomment-437768115