Re: [quicwg/base-drafts] kMaxDatagramSize -> max_datagram_size (#3167)

Martin Thomson <notifications@github.com> Tue, 29 October 2019 22:30 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5A5C2120118 for <quic-issues@ietfa.amsl.com>; Tue, 29 Oct 2019 15:30:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YG_ULWenoh5x for <quic-issues@ietfa.amsl.com>; Tue, 29 Oct 2019 15:30:29 -0700 (PDT)
Received: from out-19.smtp.github.com (out-19.smtp.github.com [192.30.252.202]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C811D12001E for <quic-issues@ietf.org>; Tue, 29 Oct 2019 15:30:28 -0700 (PDT)
Received: from github-lowworker-292e294.va3-iad.github.net (github-lowworker-292e294.va3-iad.github.net [10.48.102.70]) by smtp.github.com (Postfix) with ESMTP id E71DB52091E for <quic-issues@ietf.org>; Tue, 29 Oct 2019 15:30:27 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1572388227; bh=5VYC9TMrN++9VZdMuaJw9ARKTK8cDo7cTTUjkKz7mIU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=LwC9OIbpCQ/uJjUJGpBV6Z/0Fo0ocXu7Dm0sUD0FLDGsu3BSuU5cDgYr9nEaYiHWw ujSmafuQ7ilRZ7pwCUViAQ6zPy7rm6i/iZbQjPYL4mjbbdzC4/5DSZdtyKy7MAVb1O bvWejZBFPc4wWfIDwwkRhtqYhp8HnIl9Bj9cGa1U=
Date: Tue, 29 Oct 2019 15:30:27 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2RF4KS6FKCGLUAVCF3YXYAHEVBNHHB5JW7PY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3167/review/308873549@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3167@github.com>
References: <quicwg/base-drafts/pull/3167@github.com>
Subject: Re: [quicwg/base-drafts] kMaxDatagramSize -> max_datagram_size (#3167)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5db8bd83d8369_4b213ff93fecd95c62438"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/UHCG8b_VfPpGgUpueR978Q7TLRg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Oct 2019 22:30:31 -0000

martinthomson approved this pull request.



> @@ -1258,6 +1254,11 @@ kPersistentCongestionThreshold:
 Variables required to implement the congestion control mechanisms
 are described in this section.
 
+max_datagram_size:
+: The sender's current maximum payload size. Does not include UDP or IP
+  overhead.  The max datagram size is used for calculating initial and
+  minimum congestion windows. The RECOMMENDED value is 1200 bytes.

This can't be less than 1200.  Worth adding?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3167#pullrequestreview-308873549