Re: [quicwg/base-drafts] Clean up text on Maximum Table Size. (#2115)

Martin Thomson <notifications@github.com> Wed, 12 December 2018 00:39 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 57AAB129C6B for <quic-issues@ietfa.amsl.com>; Tue, 11 Dec 2018 16:39:24 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.056
X-Spam-Level:
X-Spam-Status: No, score=-3.056 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FRjWV5LHEQ1I for <quic-issues@ietfa.amsl.com>; Tue, 11 Dec 2018 16:39:22 -0800 (PST)
Received: from o1.sgmail.github.com (o1.sgmail.github.com [192.254.114.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6D9BE127598 for <quic-issues@ietf.org>; Tue, 11 Dec 2018 16:39:22 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=IR7koLEvfpBWfsSpsubSAfrtUBg=; b=IV2EotXnWiz9LgJs nxKcNzgdDzPvwGVdQZa3whEqquSGS8RnMMOP019GC6PNVyv+kHGppcRvkilxgOj/ og1Nv4Wzip0e3yOOCCFN3bD8kHJy/L2i56Yhzc/v9WXVr+tQCf+XF2IUXJkewEab YvImJexW7n9g5RPXzUl6yx3P7mE=
Received: by filter1002p1las1.sendgrid.net with SMTP id filter1002p1las1-1739-5C1058B9-1A 2018-12-12 00:39:21.710980782 +0000 UTC m=+92146.254816279
Received: from github-lowworker-56a5eb2.cp1-iad.github.net (unknown [192.30.252.33]) by ismtpd0036p1iad2.sendgrid.net (SG) with ESMTP id mPsjVnOlTU6JS28g_5z2yA for <quic-issues@ietf.org>; Wed, 12 Dec 2018 00:39:21.536 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-56a5eb2.cp1-iad.github.net (Postfix) with ESMTP id 947E2C11AD for <quic-issues@ietf.org>; Tue, 11 Dec 2018 16:39:21 -0800 (PST)
Date: Wed, 12 Dec 2018 00:39:21 +0000
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abb608ee043ab4be7f9d1f0f9dcc34a5132966d91092cf0000000118281ab992a169ce173d8649@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2115/review/183947287@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2115@github.com>
References: <quicwg/base-drafts/pull/2115@github.com>
Subject: Re: [quicwg/base-drafts] Clean up text on Maximum Table Size. (#2115)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c1058b992e72_738d3fed934d45c01739fb"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak11pyVtPqEJxZs+c6HxoDtvoFnt9EnROvuwdO ZNg9gPlF1aw8rAu+MEt/miNSUF3SaTn/eDbefwRfHUJVuR+JeTJwjcZrNzY/GIDicH1aeN1JCiT8Vg xBQ+1X+55p6AvilOUQKHslG6GAYASejlzHY//ORO8rC/rAL335txTwfaqKrdW8KTACZp9E1xgDldSw 0=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/YGfchTP2KYgPZr0MyJ-KdFw_AKA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Dec 2018 00:39:25 -0000

martinthomson requested changes on this pull request.

I think that we should instead refer to the current limit as the "Table Size" or "Dynamic Table Size" and reserve "Maximum Table Size" to refer to the maximum value that can take.  In other words, Maximum refers to the setting.

Not sure how to review the moved text.  How much changed?

>  
-~~~
-   MaxEntries = floor( MaxTableSize / 32 )
-~~~
+### Maximum Table Size

I think that we need to use "Table Size" for this concept and reserve the maximum table size for the setting.

That invalidates much of this.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2115#pullrequestreview-183947287