Re: [quicwg/base-drafts] Unify TLP and RTO into Probe Timeout (#2114)

[Subodh Iyengar <[e-mail]>]

siyengar commented on this pull request.



> @@ -1157,6 +1095,9 @@ window.
        congestion_window *= kLossReductionFactor
        congestion_window = max(congestion_window, kMinimumWindow)
        ssthresh = congestion_window
+       // Collapse congestion window if persistent congestion
+       if (pto_count > 2):

i think this condition will bring back the issue that i raised previously of a longer timeout.

Consider this case:

1 [acked], 2, 3[pto], 4[pto], 5 [pto]

-> ack 5

now we get into a state

1 [acked], 2 [lost], 3[outsatding], 4[outstanding], 5 [acked]

since minCwnd = 2

you end up with consuming the cwnd fully still and will have to wait until another pto to get out of this case.

The previous logic intentionally cleared all packets < rto_verified packet to avoid this which I had raised in a previous issue and is intentional




-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2114#discussion_r241663171