Re: [quicwg/base-drafts] Add OnPacketReceived to pseudocode (#3653)

Martin Thomson <notifications@github.com> Thu, 14 May 2020 00:58 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C3DA83A08B2 for <quic-issues@ietfa.amsl.com>; Wed, 13 May 2020 17:58:46 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.273
X-Spam-Level:
X-Spam-Status: No, score=-3.273 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.173, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7TItcDux_qLg for <quic-issues@ietfa.amsl.com>; Wed, 13 May 2020 17:58:45 -0700 (PDT)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4FA693A08A6 for <quic-issues@ietf.org>; Wed, 13 May 2020 17:58:45 -0700 (PDT)
Received: from github-lowworker-f62aa54.va3-iad.github.net (github-lowworker-f62aa54.va3-iad.github.net [10.48.17.68]) by smtp.github.com (Postfix) with ESMTP id 0705F660A02 for <quic-issues@ietf.org>; Wed, 13 May 2020 17:58:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1589417924; bh=IeC6PdArkYG5nZj1ZuAj04SjCmc+laApD4vd0a7/Zn4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=oNVko/PDHkfjSyCCjlKiKmaWcBcBtfqHLHpLPKiEgxgVmMRhzvG8Xpgagjm09Cj7d sWMVJ+5CFsghjbNJ5U1DCzaReB256rWwyOvDTaKAEJ2TCGzzTqxI3aLZ0Gz9l7Q5/N I5hPrqeu6KOJ9I6GGrds7UkjuTz59zg1++e5aeXs=
Date: Wed, 13 May 2020 17:58:43 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKY5XHIQSTFRTDHAZYF4ZB4MHEVBNHHCJTOADM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3653/review/411395226@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3653@github.com>
References: <quicwg/base-drafts/pull/3653@github.com>
Subject: Re: [quicwg/base-drafts] Add OnPacketReceived to pseudocode (#3653)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ebc97c3ebdee_3b9c3fed97acd96441819"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ZruX6_TWhn2xLma67r_vPskdxA0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 14 May 2020 00:58:47 -0000

@martinthomson commented on this pull request.

Thanks for doing this.  I have one tweak that I think you need and maybe a tweak that you want.

The first is about the argument and what information is passed.  I think that this is just a notification from the main packet processing code, so it doesn't need to include packet processing.

The second is more involved and would involve adding more state variables.

> @@ -1142,6 +1142,21 @@ Pseudocode for OnPacketSent follows:
      SetLossDetectionTimer()
 ~~~
 
+## On Receiving a Packet
+
+When a packet is received, it may allow the server to send
+if the server was previously amplification limited.
+
+Psuedocode for OnPacketReceived follows:
+
+~~~
+OnPacketReceived(packet):
+  // If this packet unblocks the server, arm the

This is fine.  The alternative I considered was:

```
  if (server and peer address is not validated):
    was_blocked = aa_bytes_sent >= aa_bytes_received * 3
    aa_bytes_received += datagram.size()
    if was_blocked:
        SetLossDetectionTimer()
```
But this is fine.  In order for that to work, you need to have global state variables for aa_bytes_sent and aa_bytes_received, which you don't otherwise have.

> @@ -1142,6 +1142,21 @@ Pseudocode for OnPacketSent follows:
      SetLossDetectionTimer()
 ~~~
 
+## On Receiving a Packet
+
+When a packet is received, it may allow the server to send
+if the server was previously amplification limited.
+
+Psuedocode for OnPacketReceived follows:
+
+~~~
+OnPacketReceived(packet):

I would drop the argument to this.  Because this needs to be a datagram not a packet.

That means the function at the end should be called ProcessPackets(datagram) if you keep it.  But I would suggest that you don't need to do packet processing in this logic: this is just a function where the loss recovery code is told about what is happening in the main code.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3653#pullrequestreview-411395226