IETF Logo Mail Archive

Re: [quicwg/base-drafts] Add note about frequent RTT estimates (#2340)

ianswett <notifications@github.com> Thu, 17 January 2019 09:46 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B0B8A130DCD for <quic-issues@ietfa.amsl.com>; Thu, 17 Jan 2019 01:46:53 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -11.149
X-Spam-Level:
X-Spam-Status: No, score=-11.149 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YS4Yhy_kGznF for <quic-issues@ietfa.amsl.com>; Thu, 17 Jan 2019 01:46:52 -0800 (PST)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 03CD6130DFA for <quic-issues@ietf.org>; Thu, 17 Jan 2019 01:46:52 -0800 (PST)
Date: Thu, 17 Jan 2019 01:46:50 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1547718410; bh=n1mpOrsNh2U+9udpCnB8ZCG0NDGFuhrypVGum1n7hYk=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Ifvc9KfGFdvcuvTHeWZtIodEpMGxIUeFxRNm+0Ut8fPWnky8TCc0aTZvwZEj0V/fa XlOEMca2zqHisUaycEKS/L+MTB21b/JeY3LDmXs1Nkk8qYpuBiLPori7jF8/lg/rtx J9W/hFWgimeN4NyN0bWRxi85g16QArFiAoYMeEZ4=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4aba69a333d671568ab4bb436827fba52064f400aea92cf000000011858110a92a169ce17d8cc13@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2340/review/193534236@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2340@github.com>
References: <quicwg/base-drafts/pull/2340@github.com>
Subject: Re: [quicwg/base-drafts] Add note about frequent RTT estimates (#2340)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c404f0addaeb_2e113fa7906d45bc24251c"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/bIDyWPymqYArpTT2W1oXNLcDUfg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Jan 2019 09:46:54 -0000

ianswett commented on this pull request.



> @@ -292,6 +292,10 @@ ack delay field should be ignored.
 Like TCP, QUIC calculates both smoothed RTT and RTT variance similar to those
 specified in {{?RFC6298}}.
 
+A sender might take multiple samples per RTT, and as suggested in {{?RFC6298}},

```suggestion
Taking a sample from every ACK with a larger largest acked is likely to cause a sender to take multiple samples per RTT, and as suggested in {{?RFC6298}},
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2340#pullrequestreview-193534236

v2.23.0 | Report a Bug | By Email