IETF Logo Mail Archive

Re: [quicwg/base-drafts] Add note about frequent RTT estimates (#2340)

ianswett <notifications@github.com> Sat, 19 January 2019 08:34 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8A1B112DD85 for <quic-issues@ietfa.amsl.com>; Sat, 19 Jan 2019 00:34:23 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -11.149
X-Spam-Level:
X-Spam-Status: No, score=-11.149 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mDAJewXhN8Es for <quic-issues@ietfa.amsl.com>; Sat, 19 Jan 2019 00:34:21 -0800 (PST)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8B9411228B7 for <quic-issues@ietf.org>; Sat, 19 Jan 2019 00:34:21 -0800 (PST)
Date: Sat, 19 Jan 2019 00:34:20 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1547886860; bh=L8HmXbb0DaKdhSVVckzbbU9nB9eFEEaq1wP9WGIEZi8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=eMkdNimRPgfXBRnawS1+hXZ0fHGbCvdB2LywvfMkGP4VY99i1dT270bGgeDsRE+Mu 8YgK7glHMmO3LRYr7vbG6Y5+7XaCAz9Aum8TeMVWD+kAkKQJysWDhBzh/Bn/X+oUuF 5wSPHYIn954bfk/Ee2GGYw+37nhYnRWlLYnkiOyk=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4aba2a1fe06cf054083547b9dccfc593fcd155f537092cf00000001185aa30c92a169ce17d8cc13@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2340/review/194349635@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2340@github.com>
References: <quicwg/base-drafts/pull/2340@github.com>
Subject: Re: [quicwg/base-drafts] Add note about frequent RTT estimates (#2340)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c42e10c8a1ee_56973fe0e2ad45b46489ce"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/icJD8cexNIvVUupvHa9HumzmuKE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 19 Jan 2019 08:34:23 -0000

ianswett commented on this pull request.



> @@ -289,8 +289,15 @@ be subtracted from the RTT as long as the result is larger than the min_rtt.
 If the result is smaller than the min_rtt, the RTT should be used, but the
 ack delay field should be ignored.
 
-Like TCP, QUIC calculates both smoothed RTT and RTT variance similar to those
-specified in {{?RFC6298}}.
+A sender calculates both smoothed RTT and RTT variance similar to those
+specified in {{?RFC6298}}, see {{on-ack-received}}.
+
+A sender might take multiple samples per RTT because ACK frames that are

Suggestion: "A sender will take multiple samples per RTT when ACK frames are received within an RTT that acknowledge larger packet numbers than before("

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2340#pullrequestreview-194349635

v2.23.0 | Report a Bug | By Email