[quicwg/base-drafts] Fixed handshake key deadlock issue (#3093)

martinduke <notifications@github.com> Tue, 15 October 2019 07:46 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9A58B120071 for <quic-issues@ietfa.amsl.com>; Tue, 15 Oct 2019 00:46:10 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ce_UxdNsiEA7 for <quic-issues@ietfa.amsl.com>; Tue, 15 Oct 2019 00:46:08 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AE985120013 for <quic-issues@ietf.org>; Tue, 15 Oct 2019 00:46:08 -0700 (PDT)
Date: Tue, 15 Oct 2019 00:46:07 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1571125567; bh=WGz/4UjakE4n56NkJG3KKpYskQuD7EQkB4SuZ1RcqdQ=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=ZxiXYYDscKFTVR5sZo23sdRDho63YaqryT9fNweWShOm6sZVqtFZHVdcK0SUBf8gd tjZhivTlCyPWBGFz2clwsjjv1JJVjc/I5LIUoiDCF5e1zl/07oECrhf2IUBT6y2TMg TGzHntoXc7/qnc0hyTj54NOoSQtqwHd4sGlCJTIk=
From: martinduke <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5A2JXDAIRISNA7THV3WK447EVBNHHB4OJ3YQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3093@github.com>
Subject: [quicwg/base-drafts] Fixed handshake key deadlock issue (#3093)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5da5793fe2e36_4b3b3fb6852cd960486092"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinduke
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/iwV_l5Cd-8h92W6V4zh2y7nPrj8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Oct 2019 07:46:11 -0000

Along with some other PRs, I believe this fixes #2863.

Fundamentally, there are four ways to solve the problem of one endpoint throwing away the handshake keys while the other has no 1-RTT data.

1) Keep the handshake keys forever
2) Make the endpoint start a 1-RTT PTO timer whether or not it has data to send
3) Require each endpoint to send a retransmittable frame soon after the handshake is complete; or
4) Make the endpoint wait until it receives an ack-eliciting 1-RTT packet, in addition to a 1-RTT ack.

I believe that the discard keys group might have a plurality for #4. The added condition makes sure that the peer&#39;s PTO machinery has started and will have little effect on most applications, including HTTP3.

This PR is a concrete statement of the fourth option.
You can view, comment on, or merge this pull request online at:

  https://github.com/quicwg/base-drafts/pull/3093

-- Commit Summary --

  * Fixed handshake key deadlock issue

-- File Changes --

    M draft-ietf-quic-tls.md (9)

-- Patch Links --

https://github.com/quicwg/base-drafts/pull/3093.patch
https://github.com/quicwg/base-drafts/pull/3093.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3093