Re: [quicwg/base-drafts] Change PTO to be per packet number space (#3066)

martinduke <notifications@github.com> Tue, 15 October 2019 07:14 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E0035120041 for <quic-issues@ietfa.amsl.com>; Tue, 15 Oct 2019 00:14:32 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.454
X-Spam-Level:
X-Spam-Status: No, score=-6.454 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DYgBV9Jtm4on for <quic-issues@ietfa.amsl.com>; Tue, 15 Oct 2019 00:14:31 -0700 (PDT)
Received: from out-16.smtp.github.com (out-16.smtp.github.com [192.30.254.199]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7795E120013 for <quic-issues@ietf.org>; Tue, 15 Oct 2019 00:14:31 -0700 (PDT)
Date: Tue, 15 Oct 2019 00:14:30 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1571123671; bh=pscjw3LJ83cUCiGUWnXIHfj1pyvlB6Z/cOvy6wIvmL0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=cQLKJfHtn2Z2+RIpMSdejpwHyw5lp7DRMNeVkTfjY7ZTSagPF4YHQ4OUz/TD4hWX9 c2cbG/51zI0v8KbLsuoWDwHc9SjCMF2eNGG99PwUEhk0zfGXxQdFL7LsRsEPEOWYHi w+6cyoHbEhCTnu3Ibg1OK+ZA4Kx5W3XTwAtsxC6g=
From: martinduke <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZP7VOS6EX2GTJECOF3WKZGNEVBNHHB3LP3EA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3066/review/301693575@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3066@github.com>
References: <quicwg/base-drafts/pull/3066@github.com>
Subject: Re: [quicwg/base-drafts] Change PTO to be per packet number space (#3066)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5da571d6ab6ef_4a863fa7d18cd9681353dd"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinduke
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/kdELaXhUDAPpn6mqrK_rO6abbQI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Oct 2019 07:14:33 -0000

martinduke requested changes on this pull request.

As discussed this afternoon, as written this implies up to six packets sent per PTO interval. While I could live with that, I think we should limit it to "no more than one datagram per crypto level, but at least two datagrams" or something to that effect.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3066#pullrequestreview-301693575