Re: [quicwg/base-drafts] Change PTO to be per packet number space (#3066)

[Marten Seemann <[e-mail]>]

marten-seemann requested changes on this pull request.

We also need to update the `OnLossDetectionTimeout` function. If I understand this PR correctly, the code should be:

```
OnLossDetectionTimeout():
  earliest_loss_time, pn_space = GetEarliestTimeAndSpace(loss_time)
  if (earliest_loss_time != 0):
    // Time threshold loss Detection
    DetectLostPackets(pn_space)
    SetLossDetectionTimer()
    return

  if (endpoint is client without 1-RTT keys):
    // Client sends an anti-deadlock packet: Initial is padded
    // to earn more anti-amplification credit,
    // a Handshake packet proves address ownership.
    if (has Handshake keys):
      SendOneAckElicitingHandshakePacket()
    else:
      SendOneAckElicitingPaddedInitialPacket()
  else:
    // PTO. Send new data if available, else retransmit old data.
    // If neither is available, send a single PING frame.
    pn_space, _ = GetEarliestTimeAndSpace(time_of_last_sent_ack_eliciting_packet)
    SendOneOrTwoAckElicitingPackets(pn_space)

  pto_count++
  SetLossDetectionTimer()
```

> @@ -1119,7 +1125,7 @@ PeerNotAwaitingAddressValidation():
          has received 1-RTT ACK
 
 SetLossDetectionTimer():
-  loss_time, _ = GetEarliestLossTime()
+  loss_time, _ = GetEarliestTimeAndSpace(loss_time)

Using `loss_time` here is confusing (and wouldn't compile in any language).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3066#pullrequestreview-306934189