IETF Logo Mail Archive

Re: [quicwg/base-drafts] Fixing max_ack_delay (#3938)

Kazu Yamamoto <notifications@github.com> Thu, 20 August 2020 05:42 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 012223A077A for <quic-issues@ietfa.amsl.com>; Wed, 19 Aug 2020 22:42:21 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.006
X-Spam-Level:
X-Spam-Status: No, score=-2.006 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_16=1.092, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QzPD-OUBEo-U for <quic-issues@ietfa.amsl.com>; Wed, 19 Aug 2020 22:42:19 -0700 (PDT)
Received: from out-10.smtp.github.com (out-10.smtp.github.com [192.30.254.193]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CE07C3A0772 for <quic-issues@ietf.org>; Wed, 19 Aug 2020 22:42:19 -0700 (PDT)
Received: from github-lowworker-275fa97.va3-iad.github.net (github-lowworker-275fa97.va3-iad.github.net [10.48.17.64]) by smtp.github.com (Postfix) with ESMTP id E8461580E71 for <quic-issues@ietf.org>; Wed, 19 Aug 2020 22:42:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1597902139; bh=XJ45ZRkYSUaSP8zAiyFC+a/Eo098VOE9uSEMCZAbDKU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=eqguv2Vclk9C2nqhJBNEciVpUME3DJ8pLAkserc3SJuOcEnkJpBMxxRcszv89hPBh lH6qxG/9dCOrJbE9NuiJTN6Ao56HbsDG+IlsTFflnAndVei7PDtlr46kqNHn1NIfOk cj6oVAFfArUuDAxaHf5LQSfbYRB0Yklb8LNsQDv4=
Date: Wed, 19 Aug 2020 22:42:18 -0700
From: Kazu Yamamoto <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3JHRK7LIWVE6WXQDV5JHXDVEVBNHHCPC5BAU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3938/c677174800@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3938@github.com>
References: <quicwg/base-drafts/pull/3938@github.com>
Subject: Re: [quicwg/base-drafts] Fixing max_ack_delay (#3938)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f3e0d3aa2070_a7d1964634648"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazu-yamamoto
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/lQ9FAwhwrVtrIH8ZIOsqRhoDX5I>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Aug 2020 05:42:21 -0000

OK. I understand. But honestly, it is difficult at least for me to understand the intention of the pseudocode. If `UpdateRTT` had a guard clause where `ack_delay` is set to 0 if the packet space is Initial or Handshake, it would much help. But this function does not take the packet space as argument, sigh.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3938#issuecomment-677174800

v2.23.0 | Report a Bug | By Email