IETF Logo Mail Archive

Re: [quicwg/base-drafts] Fixing max_ack_delay (#3938)

Martin Thomson <notifications@github.com> Thu, 23 July 2020 02:15 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5BC9D3A0B51 for <quic-issues@ietfa.amsl.com>; Wed, 22 Jul 2020 19:15:05 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.555
X-Spam-Level:
X-Spam-Status: No, score=-1.555 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jM661QXEnt0H for <quic-issues@ietfa.amsl.com>; Wed, 22 Jul 2020 19:15:04 -0700 (PDT)
Received: from out-27.smtp.github.com (out-27.smtp.github.com [192.30.252.210]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 29C603A0B4F for <quic-issues@ietf.org>; Wed, 22 Jul 2020 19:15:04 -0700 (PDT)
Received: from github-lowworker-1ac52d7.ash1-iad.github.net (github-lowworker-1ac52d7.ash1-iad.github.net [10.56.25.52]) by smtp.github.com (Postfix) with ESMTP id 829FFE009E for <quic-issues@ietf.org>; Wed, 22 Jul 2020 19:15:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1595470503; bh=ulY6ajhKlCfaGsuL8B66pvbX5i0sr3LW60iVSAyVRNI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=a+y/SPoLtuL+dkvEWN3v8cxX+AbTkWRE76pGcdr/bVsHcPk2+MqXkHienUuezTyEZ 3EMySfuBv6odKX85Myol1GqlgJ5/xs9hceSofG5vBQLSlH/AA91wiZzI+JOY30d9v5 bv4P4qDDQqUQA5Ha9u/bSlSnXeFMx1WB4BGBHiAo=
Date: Wed, 22 Jul 2020 19:15:03 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK64CDDT6DEMPHVSA6V5ETJ2PEVBNHHCPC5BAU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3938/review/453800109@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3938@github.com>
References: <quicwg/base-drafts/pull/3938@github.com>
Subject: Re: [quicwg/base-drafts] Fixing max_ack_delay (#3938)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f18f2a76e6d8_462a3fef704cd96c85162"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ZActVIRfwd9dM1oUF8YTzOO09P8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Jul 2020 02:15:05 -0000

@martinthomson requested changes on this pull request.



> +     ack_delay = 0
+     if (pn_space == ApplicationData):
+       ack_delay = max_ack_delay

Based on discussions about PC elsewhere, I realized my error.  This needs to be reverted.  In fact, I would suggest that we initialize max_ack_delay to 25ms for that reason.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3938#pullrequestreview-453800109

v2.23.0 | Report a Bug | By Email