Re: [quicwg/base-drafts] Clarify ACK of ACKs and bundling a PING (#2794)

[Kazuho Oku <[e-mail]>]

kazuho approved this pull request.

LGTM, though I have very nit-picky comments.

> @@ -2860,12 +2860,13 @@ valid frames? -->
 ### Sending ACK Frames
 
 An endpoint MUST NOT send more than one packet containing only an ACK frame per
-received packet that contains frames other than ACK and PADDING frames.
-An endpoint MUST NOT send a packet containing only an ACK frame in response
-to a packet containing only ACK or PADDING frames, even if there are packet
-gaps which precede the received packet. This prevents an indefinite feedback
-loop of ACKs. The endpoint MUST however acknowledge packets containing only
-ACK or PADDING frames when sending ACK frames in response to other packets.
+received non-ACK-eliciting packet(ie: one containing only ACK and/or PADDING

Maybe "MUST NOT send more than one non-ACK-eliciting packet in response to one non-ACK-eliciting packet"?

The packet the endpoint sends can also be a combination of ACK and PADDING.

> @@ -2860,12 +2860,13 @@ valid frames? -->
 ### Sending ACK Frames
 
 An endpoint MUST NOT send more than one packet containing only an ACK frame per
-received packet that contains frames other than ACK and PADDING frames.
-An endpoint MUST NOT send a packet containing only an ACK frame in response
-to a packet containing only ACK or PADDING frames, even if there are packet
-gaps which precede the received packet. This prevents an indefinite feedback
-loop of ACKs. The endpoint MUST however acknowledge packets containing only
-ACK or PADDING frames when sending ACK frames in response to other packets.
+received non-ACK-eliciting packet(ie: one containing only ACK and/or PADDING
+frames).  An endpoint MUST NOT send a packet containing only an ACK frame in

Here also.

> @@ -2883,16 +2884,21 @@ needing acknowledgement are received.  The sender can use the receiver's
 Strategies and implications of the frequency of generating acknowledgments are
 discussed in more detail in {{QUIC-RECOVERY}}.
 
+An endpoint that is only sending ACK frames will not receive acknowledgments

Maybe s/only sending ACK frames/only sending acknowledgements/.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2794#pullrequestreview-251470349