Re: [quicwg/base-drafts] Clarify ACK of ACKs and bundling a PING (#2794)

Martin Thomson <notifications@github.com> Tue, 18 June 2019 22:28 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9C433120466 for <quic-issues@ietfa.amsl.com>; Tue, 18 Jun 2019 15:28:46 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5nf6gYvXqdoL for <quic-issues@ietfa.amsl.com>; Tue, 18 Jun 2019 15:28:44 -0700 (PDT)
Received: from out-16.smtp.github.com (out-16.smtp.github.com [192.30.254.199]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3E1A7120448 for <quic-issues@ietf.org>; Tue, 18 Jun 2019 15:28:44 -0700 (PDT)
Date: Tue, 18 Jun 2019 15:28:42 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1560896923; bh=yIgpXengErTc8p+TtPPL8L0laqWUMWAyo3LS/ttzcU4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=atFGneGqDQK8U6meuO2PlYWBV44EMgJoAwPKbBUlB2e+t0MOSnHQNyvcVzCnm8DKJ X9nj90hymPStluxL1OeVzg7TqyuxMFkPsRTFR6D+4OwbEmGmA0NLqvxFgjNbGJ7qdS AMps54TodRKmXOCYRB5MIvqOFfiW8YqMWyaZc7H4=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK45XBD5HYPKHIEPEXN3C2MBVEVBNHHBWNLZWA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2794/review/251394349@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2794@github.com>
References: <quicwg/base-drafts/pull/2794@github.com>
Subject: Re: [quicwg/base-drafts] Clarify ACK of ACKs and bundling a PING (#2794)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d09659ae1ee0_15703fa7fa4cd95c4792e5"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/TyUsQRgw0A1JSsFkNXPJJhTY89U>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Jun 2019 22:28:54 -0000

martinthomson approved this pull request.



>  To limit ACK Ranges (see {{ack-ranges}}) to those that have not yet been
 received by the sender, the receiver SHOULD track which ACK frames have been
 acknowledged by its peer. The receiver SHOULD exclude already acknowledged
 packets from future ACK frames whenever these packets would unnecessarily
-contribute to the ACK frame size.
-
-Because ACK frames are not sent in response to ACK-only packets, a receiver that
-is only sending ACK frames will only receive acknowledgements for its packets if
-the sender includes them in packets with non-ACK frames.  A sender SHOULD bundle
-ACK frames with other frames when possible.
+contribute to the ACK frame size.  When the receiver is only sending non
+ACK-eliciting packets, it can bundle a PING with a fraction of them, such as one

non-ACK-eliciting?

> @@ -2883,16 +2884,21 @@ needing acknowledgement are received.  The sender can use the receiver's
 Strategies and implications of the frequency of generating acknowledgments are
 discussed in more detail in {{QUIC-RECOVERY}}.
 
+ACK-only packets are only sent in response to ACK-eliciting packets, so a
+receiver that is only sending ACK frames will only receive acknowledgements
+for its packets if the sender includes them in packets with ACK-eliciting

An endpoint that is only sending ACK frames won't receive acknowledgments from its peer unless those acknowledgements are included in packets [...] 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2794#pullrequestreview-251394349