Re: [quicwg/base-drafts] Ignore loss of undecryptable packets (#2028)
Martin Thomson <notifications@github.com> Wed, 21 November 2018 02:55 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 145B01286E7 for <quic-issues@ietfa.amsl.com>; Tue, 20 Nov 2018 18:55:04 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z9L7TGkW1Blj for <quic-issues@ietfa.amsl.com>; Tue, 20 Nov 2018 18:55:02 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C69DD126DBF for <quic-issues@ietf.org>; Tue, 20 Nov 2018 18:55:01 -0800 (PST)
Date: Tue, 20 Nov 2018 18:55:00 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1542768900; bh=cBdDuNEcAtftYJlegmU+li8CiixMa9DrHfYw+9wld5w=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=SJ+C3/8plrPQ14GifsAmGsMDffi7KyABgVVycQlucOYsTo/Rc79Px4aVzmliIeuX3 qJGR0q0xHWNaIub9NG/luWTU6GQnOHoqoEihEPAPAo9pB3EnlRWEjAmqzIyPHQChmW Cu42AL1n7qO4kBLLw3DcI7lbGD2Is5+P+aOEO95k=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab986bf5bf0a98879937969efd2e2052af7689ed8b92cf00000001180c8b0492a169ce16d1c244@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2028/review/177058417@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2028@github.com>
References: <quicwg/base-drafts/pull/2028@github.com>
Subject: Re: [quicwg/base-drafts] Ignore loss of undecryptable packets (#2028)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bf4c90499430_39f83fe0c00d45b8176483"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/mpA0zsxToNe5_M4y5YHIBrDSmJU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Nov 2018 02:55:04 -0000
martinthomson commented on this pull request. > @@ -1000,6 +999,17 @@ The recovery period limits congestion window reduction to once per round trip. During recovery, the congestion window remains unchanged irrespective of new losses or increases in the ECN-CE counter. +## Loss of protected packets during the handshake + +0RTT and 1RTT packets sent prior to handshake completion can arrive before I think that you need to identify this as early RTT packets that are sent by an endpoint with new keys. Also, expand on that: Handshake and 0-RTT from the client, and 1-RTT from either endpoint. > @@ -1000,6 +999,17 @@ The recovery period limits congestion window reduction to once per round trip. During recovery, the congestion window remains unchanged irrespective of new losses or increases in the ECN-CE counter. +## Loss of protected packets during the handshake Title Case Headings ```suggestion ## Reordering of Packets Sent with New Keys ``` > @@ -1000,6 +999,17 @@ The recovery period limits congestion window reduction to once per round trip. During recovery, the congestion window remains unchanged irrespective of new losses or increases in the ECN-CE counter. +## Loss of protected packets during the handshake + +0RTT and 1RTT packets sent prior to handshake completion can arrive before +the peer has keys to unprotect them. In those cases, the peer may decide +not to buffer the packets. This will cause the packets to never be Use paragraphs: ```suggestion not to buffer the packets. Discarding packets for which there are no keys will result in the packets never being ``` > @@ -1000,6 +999,17 @@ The recovery period limits congestion window reduction to once per round trip. During recovery, the congestion window remains unchanged irrespective of new losses or increases in the ECN-CE counter. +## Loss of protected packets during the handshake + +0RTT and 1RTT packets sent prior to handshake completion can arrive before +the peer has keys to unprotect them. In those cases, the peer may decide +not to buffer the packets. This will cause the packets to never be +acknowledged and eventually declared lost, despite being delivered to +the peer. If the server rejects 0RTT, then the congestion controller Rejecting 0-RTT is a completely different concept that you should separate out. > @@ -1000,6 +999,17 @@ The recovery period limits congestion window reduction to once per round trip. During recovery, the congestion window remains unchanged irrespective of new losses or increases in the ECN-CE counter. +## Loss of protected packets during the handshake + +0RTT and 1RTT packets sent prior to handshake completion can arrive before +the peer has keys to unprotect them. In those cases, the peer may decide +not to buffer the packets. This will cause the packets to never be +acknowledged and eventually declared lost, despite being delivered to +the peer. If the server rejects 0RTT, then the congestion controller +SHOULD ignore the loss of 0RTT packets. If any 0RTT or 1RTT packets sent +prior to knowing the peer has keys to unprotect them are lost, the +sender's congestion control MAY ignore the loss of those packets if it's +believe they were received by the peer prior to having the correct keys. ```suggestion believed they were received by the peer prior to having the correct keys. ``` Though I might instead say >A congestion controller MAY choose to ignore loss signals from packets that might have been discarded due to packet protection keys being unavailable. That's not complete, or a spec you could implement to, but it is less about belief and more about guesswork, which is what this is. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2028#pullrequestreview-177058417
- [quicwg/base-drafts] Ignore loss of undecryptable… ianswett
- Re: [quicwg/base-drafts] Ignore loss of undecrypt… Martin Thomson
- Re: [quicwg/base-drafts] Ignore loss of undecrypt… Subodh Iyengar
- Re: [quicwg/base-drafts] Ignore loss of undecrypt… MikkelFJ
- Re: [quicwg/base-drafts] Ignore loss of undecrypt… Mike Bishop
- Re: [quicwg/base-drafts] Ignore loss of undecrypt… MikkelFJ
- Re: [quicwg/base-drafts] Ignore loss of undecrypt… janaiyengar
- Re: [quicwg/base-drafts] Ignore loss of undecrypt… Martin Thomson
- Re: [quicwg/base-drafts] Ignore loss of undecrypt… Rui Paulo
- Re: [quicwg/base-drafts] Ignore loss of undecrypt… Martin Thomson
- Re: [quicwg/base-drafts] Ignore loss of undecrypt… ianswett
- Re: [quicwg/base-drafts] Ignore loss of undecrypt… ianswett
- Re: [quicwg/base-drafts] Ignore loss of undecrypt… ianswett
- Re: [quicwg/base-drafts] Ignore loss of undecrypt… ianswett
- Re: [quicwg/base-drafts] Ignore loss of undecrypt… Martin Thomson
- Re: [quicwg/base-drafts] Ignore loss of undecrypt… ianswett
- Re: [quicwg/base-drafts] Ignore loss of undecrypt… ianswett
- Re: [quicwg/base-drafts] Ignore loss of undecrypt… ianswett