Re: [quicwg/base-drafts] Consequences of bad ECN markings (#1626)

mirjak <notifications@github.com> Wed, 01 August 2018 16:15 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 18758131101 for <quic-issues@ietfa.amsl.com>; Wed, 1 Aug 2018 09:15:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.009
X-Spam-Level:
X-Spam-Status: No, score=-3.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FIeiUH82VdjM for <quic-issues@ietfa.amsl.com>; Wed, 1 Aug 2018 09:15:13 -0700 (PDT)
Received: from o3.sgmail.github.com (o3.sgmail.github.com [192.254.112.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1269F13104C for <quic-issues@ietf.org>; Wed, 1 Aug 2018 09:15:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=wXo3VJS+PPfc2dgqTU7J/jyLp4g=; b=tiqhjVJNc2K6Tr+D E1WPifakC1dqpg6B2hEPCcMR/Khx1zDrgzGLajU3IOXVphFPJ4NijSB8Bza8omyq YoexNBQjkT0va/Vw5vdqfGovuWzNKAh/TzSMYNVOwR7Wfhr95HRttj6Kf0C9mod9 rOnOid2kUqXp42Q31GtUASawM4U=
Received: by filter1306p1mdw1.sendgrid.net with SMTP id filter1306p1mdw1-1167-5B61DC8E-20 2018-08-01 16:15:10.969473182 +0000 UTC m=+582533.098229350
Received: from github-lowworker17-cp1-prd.iad.github.net (unknown [192.30.252.44]) by ismtpd0006p1iad2.sendgrid.net (SG) with ESMTP id qQgomyTXQJaMmVsIQRAJgw for <quic-issues@ietf.org>; Wed, 01 Aug 2018 16:15:11.131 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker17-cp1-prd.iad.github.net (Postfix) with ESMTP id 12CA4C18CB for <quic-issues@ietf.org>; Wed, 1 Aug 2018 09:15:11 -0700 (PDT)
Date: Wed, 01 Aug 2018 16:15:11 +0000
From: mirjak <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab97d28235e13e1bc6ac98b8d4081bfbf22d76b1d692cf0000000117799e8f92a169ce14a69ac0@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1626/review/142453295@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1626@github.com>
References: <quicwg/base-drafts/pull/1626@github.com>
Subject: Re: [quicwg/base-drafts] Consequences of bad ECN markings (#1626)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b61dc8f112ca_faf3ff7a02be620205556"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mirjak
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3LDI9WUxotSB2mD8F2TF0ePELigMuu3WobDb S8WXZAmiWwqMhCIY7Utv4lFFD4G0clgtlHDMGUdElxqV8SNUNfxNlJ6DNBZpYdmo9nPbeiGulm/yeQ BVCcrO+3kB15R8eLwKRDVlN5zRXcdzkgEZB2qMbc50N/RRVauI9p6rjwQA==
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/whUTNeIhV-YeyniNwlfYVrx55qc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Aug 2018 16:15:17 -0000

mirjak commented on this pull request.



> +peer.  Suppressing reports of ECN-CE markings could cause a peer to increase
+their send rate.  This increase could result in congestion and loss.
+
+An endpoint MAY attempt to detect suppression of reports by marking occasional
+packets that they send with ECN-CE.  If a packet marked with ECN-CE is not
+reported as having been marked when the packet is acknowledged, the endpoint
+SHOULD then disable ECN for that path.
+
+Reporting additional ECN-CE markings will cause a peer to reduce their sending
+rate, which is similar in effect to advertising reduced connection flow control
+limits and so no advantage is gained by doing so.
+
+Endpoints choose the congestion controller that they use.  Though congestion
+controllers ideally use reports of ECN markings as input, the exact response for
+each controller could be different.  Failure to correctly respond to information
+about ECN markings is therefore difficult to detect.

Actually this is a bit weak. RFC3168 say
"Upon the receipt by an ECN-Capable transport of a single CE
packet, the congestion control algorithms followed at the end-
systems MUST be essentially the same as the congestion control
response to a single dropped packet."
(where RFC8311 adds a
"unless otherwise specified by an Experimental RFC in the IETF document stream"
to this last sentence, however, this is not really important here).

The text as currently written indicates that the congestion controller can choose to account for ECN information at all or not which is not the case.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1626#pullrequestreview-142453295