Re: [quicwg/base-drafts] Do not reset pto_count on Initial ACKs (#3551)

Kazuho Oku <notifications@github.com> Tue, 31 March 2020 23:57 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C395E3A0DB5 for <quic-issues@ietfa.amsl.com>; Tue, 31 Mar 2020 16:57:17 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.082
X-Spam-Level:
X-Spam-Status: No, score=0.082 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.282, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4--YcisirtZL for <quic-issues@ietfa.amsl.com>; Tue, 31 Mar 2020 16:57:15 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B4DB23A0DB4 for <quic-issues@ietf.org>; Tue, 31 Mar 2020 16:57:15 -0700 (PDT)
Date: Tue, 31 Mar 2020 16:57:14 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1585699034; bh=OTrg/Y9G/V3us//mcRX/Tde/Sxtl2oeJzoKWZoqkRF0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=BkTRYBK9pb8i5qwLUZ0vBVLfc5nm+b6MJ118yLnIvs+3BRS+kv3vqcXi1mYxmod3j LdJana3YVB9w0CvfUF2pFC6aZvKox9KEkoB8SSvcNwux5HKWmaIHs7JV6LwTrssRIc Nyx2PVT4OICA7JJrwiikGjugnhi0kbJIrzLnEwvs=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4X7GS5LVDJNRRJBBV4R645VEVBNHHCGKCD2A@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3551/review/385182361@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3551@github.com>
References: <quicwg/base-drafts/pull/3551@github.com>
Subject: Re: [quicwg/base-drafts] Do not reset pto_count on Initial ACKs (#3551)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e83d8da94685_3d663f8347acd9601068fc"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/zdSb2fCfACq1IVnnDp5OhC0BztU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Mar 2020 23:57:18 -0000

@kazuho commented on this pull request.



> @@ -501,7 +501,13 @@ and prevents a server from sending a 1-RTT packet on a PTO expiration before it
 has the keys to process an acknowledgement.
 
 When a PTO timer expires, the PTO period MUST be set to twice its current
-value. This exponential reduction in the sender's rate is important because
+value. The PTO period is set back to the original value upon receiving an
+acknowledgement for a non-Initial packet. The PTO timer is not decreased when
+the client receives an Initial ACK to ensure the client's anti-deadlock timer

How about changing the text to something like: _The PTO period is set back to the original value when receiving an acknowledgement, if the endpoint knows that the peer has completed address validation. The PTO timer is not decreased while the peer is validating the address, to ensure the endpoint's anti-deadlock timer does not fire..._

I think that is our intent.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3551#pullrequestreview-385182361