Re: [EXTERNAL] Re: WGLC review of draft-ietf-quic-recovery-29

Spencer Dawkins at IETF <spencerdawkins.ietf@gmail.com> Mon, 20 July 2020 22:11 UTC

Return-Path: <spencerdawkins.ietf@gmail.com>
X-Original-To: quic@ietfa.amsl.com
Delivered-To: quic@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 175EC3A1020 for <quic@ietfa.amsl.com>; Mon, 20 Jul 2020 15:11:18 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id obj9E_6LCHFA for <quic@ietfa.amsl.com>; Mon, 20 Jul 2020 15:11:15 -0700 (PDT)
Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5E3593A0F8E for <quic@ietf.org>; Mon, 20 Jul 2020 15:11:15 -0700 (PDT)
Received: by mail-lf1-x135.google.com with SMTP id k17so10570411lfg.3 for <quic@ietf.org>; Mon, 20 Jul 2020 15:11:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=q7j5VYLkfIZRUPS5nQif53y0H64c9/jBjTbV7b5sES4=; b=QQqxQbfUQqJZaorUUScN1grq69seIvSi5ma63ZLLjkGKDkCf45kMDqNVkEWbTnCBB4 s+6sj1NFnZ8XpgH00kkNh1ANDdLhsHm2fRKZ3pqBP0dt/cMWZ1h+lKauwjq0+FAbo++G R+VthGC2mjhzW+X90MzoELRzXUiKPR3r7P9Zsiza5KySEvNr4k55B4KVT/0/e1PX0NsK a20uFbuRynNqqDgMOwNdfG48AeaMr6tV/Ymn6H5SdHW3U/NEQNRAbsM31fI07o0f42Fc mt3jyNEMri8dzUCH9FC+WZxO0kwFDfwU/UedpCl4Etzn7wTr41G3usNQcGFLQ/yEN31X ycTw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=q7j5VYLkfIZRUPS5nQif53y0H64c9/jBjTbV7b5sES4=; b=LFqFjU0xQKkYUDQZipSAg1B192XXOPOpbZd5IIahTYXoPO3t7bQMNmi17PLCaOmioS 9ib0eYegx4kVevh+7WFKNinfZdbZk90pruBCYEcIxa+D/um/0Wi1z3tI1hufmIOOc16v Azzsc6S/KaK29lJh7IDmhyrlmFGJ0UDu5ezxfYmLt61bqQsQVuinkFdGWHR3y3AmoHXP dprAzHrAes7Md8NyaOWL/av8S595ApdlUVMCZCA9so2Bfc5WB0tu6Rw5RjIVHhe47TFS VKSkhP6fXGe9FWPadmhhfxqRB6DjzcMxQEbZg2950VSKlSra8LEPEskkTKjAMIb4UkOG paXA==
X-Gm-Message-State: AOAM531WiUMOuQ3JT9sjAorrVV8eirIVWYY2Pw6nK9eHQBx2j6Ci8+5i 3Hw6IeulDZNxUYXKqrZIABpWwyPq9f4SzVa3dw4=
X-Google-Smtp-Source: ABdhPJzj+m9OhcfsCzJ1ZtHMHHf5E44HMEAb5scJj6pYfWpPrxT+JG19qgSuY/jfwzaZpvFNhtNl3O0a8GSF8GnMwVA=
X-Received: by 2002:ac2:4ec4:: with SMTP id p4mr11583115lfr.157.1595283073430; Mon, 20 Jul 2020 15:11:13 -0700 (PDT)
MIME-Version: 1.0
References: <MN2PR00MB073663726DB5AFE6885D0A6BB6670@MN2PR00MB0736.namprd00.prod.outlook.com> <9f57b20d-2eba-b2b9-d8c8-48e019c8952a@wizmail.org> <CACpbDccrpHeP5PYGCZky+AN2gC9YSs5gbAzYr4Yrw1LpvHZNiA@mail.gmail.com> <CH2PR00MB07269A73542DBC8E51E95519B67A0@CH2PR00MB0726.namprd00.prod.outlook.com> <CAKcm_gMhRX3NxiW6Primy+UrY44ZahaSO+9kF5CeeN4=XqL2JQ@mail.gmail.com> <CAKKJt-fY92k5ym767GofK+DOMQs=x6dpkwkKOA1cpkUf8Xs+3A@mail.gmail.com> <CAKcm_gPyg4QM+mZq_-E-av=u_X4nCWwdDXEH6e9Sjz1d8scEyg@mail.gmail.com>
In-Reply-To: <CAKcm_gPyg4QM+mZq_-E-av=u_X4nCWwdDXEH6e9Sjz1d8scEyg@mail.gmail.com>
From: Spencer Dawkins at IETF <spencerdawkins.ietf@gmail.com>
Date: Mon, 20 Jul 2020 17:11:01 -0500
Message-ID: <CAKKJt-fmqjXJEUHzFT0yBXE0sLvOPcnM-oCBDZfgZQNgerRt8g@mail.gmail.com>
Subject: Re: [EXTERNAL] Re: WGLC review of draft-ietf-quic-recovery-29
To: Ian Swett <ianswett@google.com>
Cc: Praveen Balasubramanian <pravb@microsoft.com>, Jana Iyengar <jri.ietf@gmail.com>, QUIC WG <quic@ietf.org>
Content-Type: multipart/alternative; boundary="000000000000e8772305aae6c856"
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic/H6DzPYKGPZFen0Hxvv1esZgWPyU>
X-BeenThere: quic@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Main mailing list of the IETF QUIC working group <quic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic>, <mailto:quic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic/>
List-Post: <mailto:quic@ietf.org>
List-Help: <mailto:quic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic>, <mailto:quic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Jul 2020 22:11:18 -0000

Hi, Ian,

On Mon, Jul 20, 2020, 16:33 Ian Swett <ianswett@google.com> wrote:

> Most of the items which I felt were somewhat deployment-specific
> constants(ie: Initial Window and Initial RTT) are 'RECOMMENDED' in the
> current recovery draft, so I thought it'd be preferable to keep that
> convention.
>

Thanks for helping me understand - this is a stylistic change.

I've had a couple of conversations outside of QUIC recently with people who
were interpreting the two terms somewhat differently, so thought it a good
time to ask.

Best,

Spencer

>
> On Mon, Jul 20, 2020 at 5:30 PM Spencer Dawkins at IETF <
> spencerdawkins.ietf@gmail.com> wrote:
>
>> Hi, Ian,
>>
>> On Mon, Jul 20, 2020 at 11:49 AM Ian Swett <ianswett=
>> 40google.com@dmarc.ietf.org> wrote:
>>
>>> I think it's ok to include burst limits in the set of things we expect
>>> may be different in DCs, but if we do that, I'd prefer to use the
>>> RECOMMENDED rather than SHOULD,
>>>
>>
>> Aren't RECOMMENDED and SHOULD equivalent in
>> https://tools.ietf.org/html/rfc2119?
>>
>> Or am I misunderstanding your point?
>>
>> 3 <https://tools.ietf.org/html/rfc2119#section-3>. SHOULD   This word, or the adjective "RECOMMENDED", mean that there
>>    may exist valid reasons in particular circumstances to ignore a
>>    particular item, but the full implications must be understood and
>>    carefully weighed before choosing a different course.
>>
>>
>> Best,
>>
>> Spencer
>>
>> since there are a number of SHOULDs which I believe apply both to the
>>> public internet and to DCs.  Then we could add a note at the top about how
>>> there are some values which are RECOMMENDED, including X, Y and Z, and
>>> those recommendations are expected to be good choices for most, but not all
>>> environments.
>>>
>>> In terms of text, I'd suggest taking Neal's suggestion and dropping an
>>> explicit mention of the public internet:
>>>
>>> Implementations MUST either use pacing or another method to limit such bursts.
>>>
>>> It is RECOMMENDED that implementations limit bursts to the initial congestion window; see Section 7.2 <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftools.ietf.org%2Fhtml%2Fdraft-ietf-quic-recovery-29%23section-7.2&data=02%7C01%7Cpravb%40microsoft.com%7C9df3e5f4f0ca4e586f0908d824e0a3ad%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637299894526657906&sdata=ze%2F7SpKUbrdgwI6m%2BS6uEGSBgc2NapVtPn9vkOYFjVs%3D&reserved=0>.
>>>
>>>
>>> On Sun, Jul 19, 2020 at 4:08 PM Praveen Balasubramanian <pravb=
>>> 40microsoft.com@dmarc.ietf.org> wrote:
>>>
>>>> >> There's a way of satisfying both desires: have the NIC handle the
>>>> pacing.
>>>>
>>>> Yes letting the NIC handle pacing will make improve CPU efficiency and
>>>> improve accuracy due to fine grained hardware timers. But that’s in the
>>>> future. Today’s NICs don’t pace large send offloads for TCP or UDP.
>>>>
>>>>
>>>>
>>>> >> Perhaps we can have a principle here: recommendations that are
>>>> specific for Internet use are just that, and we use SHOULDs for those. IW10
>>>> makes sense based on this, and I would then also be fine with changing the
>>>> MUST to a SHOULD. Perhaps we can state this principle upfront.
>>>>
>>>> I like the idea of stating that principle up front. SHOULD would be
>>>> sufficient resolution for the burst size issue.
>>>>
>>>>
>>>>
>>>> *From:* QUIC <quic-bounces@ietf.org> *On Behalf Of * Jana Iyengar
>>>> *Sent:* Friday, July 17, 2020 7:18 PM
>>>> *To:* QUIC WG <quic@ietf.org>
>>>> *Subject:* [EXTERNAL] Re: WGLC review of draft-ietf-quic-recovery-29
>>>>
>>>>
>>>>
>>>> There's a protocol question and there's a question of endpoint
>>>> behavior. In terms of the protocol itself, yes, there's no real need to
>>>> distinguish between Internet and DC environments; we've tried to ensure
>>>> that the protocol can be used broadly. My point was that the constants in
>>>> the spec were based on what we believe to be true for the public Internet,
>>>> and not for DC environments.
>>>>
>>>>
>>>>
>>>> That said, perhaps I was a bit too hasty. IW10 and InitialRTT values
>>>> are the others I was thinking about, but those are recommendations in the
>>>> spec, not requirements. And as Ian notes, there's no minimum timeout
>>>> anymore.
>>>>
>>>>
>>>>
>>>> Perhaps we can have a principle here: recommendations that are specific
>>>> for Internet use are just that, and we use SHOULDs for those. IW10 makes
>>>> sense based on this, and I would then also be fine with changing the MUST
>>>> to a SHOULD. Perhaps we can state this principle upfront.
>>>>
>>>>
>>>>
>>>> Ian, I share your hesitation that we don't want to make a distinction
>>>> between private and public networks, but we already allow for
>>>> implementations to do that with a different IW and Initial RTT. Is it
>>>> different when talking about burst limits?
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> On Fri, Jul 17, 2020 at 3:07 PM Jeremy Harris <jgh@wizmail.org> wrote:
>>>>
>>>> On 08/07/2020 22:29, Praveen Balasubramanian wrote:
>>>> > Section 7.9
>>>> > "Implementations MUST either use pacing or another method to limit
>>>> such bursts to the initial congestion window; see Section 7.2."
>>>> > This seems to preclude use of segmentation offload of sizes greater
>>>> than IW.. In datacenters we routinely send bursts that are higher without
>>>> causing loss. The MUST here seems unnecessary. It also conflicts with the
>>>> RECOMMENDED in an earlier sentence.
>>>>
>>>> There's a way of satisfying both desires: have the NIC handle the
>>>> pacing.
>>>> --
>>>> Cheers,
>>>>   Jeremy
>>>>
>>>>