Re: [EXTERNAL] Re: WGLC review of draft-ietf-quic-recovery-29

Ian Swett <ianswett@google.com> Fri, 17 July 2020 20:21 UTC

Return-Path: <ianswett@google.com>
X-Original-To: quic@ietfa.amsl.com
Delivered-To: quic@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C61673A08AC for <quic@ietfa.amsl.com>; Fri, 17 Jul 2020 13:21:08 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -17.499
X-Spam-Level:
X-Spam-Status: No, score=-17.499 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, HTML_MESSAGE=0.001, HTTPS_HTTP_MISMATCH=0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=google.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 25cxZcZfOr-D for <quic@ietfa.amsl.com>; Fri, 17 Jul 2020 13:21:06 -0700 (PDT)
Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [IPv6:2607:f8b0:4864:20::b2d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7D4983A08AA for <quic@ietf.org>; Fri, 17 Jul 2020 13:21:06 -0700 (PDT)
Received: by mail-yb1-xb2d.google.com with SMTP id a15so5073137ybs.8 for <quic@ietf.org>; Fri, 17 Jul 2020 13:21:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dX02mvPdYkAkjpAYR7TQ6tosnPq8xWr7F5E+dDBAnXI=; b=P8vq0cPvZienO6YSkfx5DoQu2Jk36tw6VDdNYPu0lS2tyUJP156HhqFpoFJ4wa0RkN 5kAZLEXSFUcivHdI+LlmBxNbCHojBrWJ7L7Y1Pq2bqWJmR5xonSKTEXEW5kD1YG59DkM QiQfGS2W4FPrrPC51n+uh+p5lTbwMfwbMHSZKoeYdweNoXPHqcY/mE97QtC8ajFuKEgg TH9RBIT6NAn0+mgavPEqOUQIr8G2ReWzT9SmQEgR1CpwpxN1U16CSew7iZnKyctk4MyI RejEZIQhAKJM6fONUr34YmsNNc1EQhWJRnPFuccr3kSRXw7AJOCxW3GS5JKNUpP1rThc EQFQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dX02mvPdYkAkjpAYR7TQ6tosnPq8xWr7F5E+dDBAnXI=; b=fGtzJ7Uqt0Ui0fo84R/TH66Fy17deRouBH3KOU/DdK5EfhUS3vGDi3ZqeUi5UzrQF4 O4o++FUAG515kprcgIJFP4smQ9tjLJdIot22sDnso3zc9YBnpBfefVYHslsaeOPulam4 lLw1jxGm7wR+XKqs3cJjut/6p2WE7QULOJxMQg9ttvMT6tdEyhMKSo4ayqW/fom0uaAz 3j+KN4EqPNrdS2HwjKmhPE7K3tHO6gTkfAaxVpYox7TZJJ9/pZbB3xCh+EJb8c6UhLan GMl8Jb/M6RWN9fSuHR7sAdUnYDdjyJfLKGhf9kNrRrXExMpxxmMr1xy1cMVd7c+IshMM RkDw==
X-Gm-Message-State: AOAM531mXST5o9HHcvEy2aSfeFE5xazsHtd/zrWJpCgRjxSYKxI764C1 T4Jv2PF/23RC7IR/8AE779fJbdTVzUg7aC+ZxfEJlg==
X-Google-Smtp-Source: ABdhPJzLIkadYUWFjRuz4fK3NvANOvgT9GZCQIiwdiSHdwHhJwoMwQhGEh9ZVnY9AsD/OmBZrQ7OQQSpcpJro/939qg=
X-Received: by 2002:a25:468b:: with SMTP id t133mr17337834yba.77.1595017265173; Fri, 17 Jul 2020 13:21:05 -0700 (PDT)
MIME-Version: 1.0
References: <MN2PR00MB073663726DB5AFE6885D0A6BB6670@MN2PR00MB0736.namprd00.prod.outlook.com> <53187d65-f7b9-b99a-f68b-b267303ab399@erg.abdn.ac.uk> <CH2PR00MB0726D18611EC030BF548CA0DB6640@CH2PR00MB0726.namprd00.prod.outlook.com> <40818629-e1dc-f0f1-6173-984a8166c7c2@erg.abdn.ac.uk> <CH2PR00MB07267EBAC2BB08CCE5160EC6B6650@CH2PR00MB0726.namprd00.prod.outlook.com> <CAKcm_gN=vizG9+kiRiX7BAfcsR1p+Q1FrTtNPXfV5vFATBNQ9Q@mail.gmail.com> <CAKKJt-c-sp=L7j5--aoEEObMjhcnTE7YVK_NE4YQFGZDtcLhrA@mail.gmail.com> <CACpbDcfrVNtDb3htqnkVqr2OOskUVr_aYTrRvssT_tAgTKqV_g@mail.gmail.com> <CAKKJt-f76tVoUiAwZrfyOEDG1FPTqbxu0Zg_Or_OymRwaNAwcw@mail.gmail.com> <CH2PR00MB0726A8F0BFBED6702448AC40B67C0@CH2PR00MB0726.namprd00.prod.outlook.com>
In-Reply-To: <CH2PR00MB0726A8F0BFBED6702448AC40B67C0@CH2PR00MB0726.namprd00.prod.outlook.com>
From: Ian Swett <ianswett@google.com>
Date: Fri, 17 Jul 2020 16:20:53 -0400
Message-ID: <CAKcm_gOSEcXxRcPx9zkiN2Aupp1A-qMyc6wP4rvdaxpnTijteQ@mail.gmail.com>
Subject: Re: [EXTERNAL] Re: WGLC review of draft-ietf-quic-recovery-29
To: Praveen Balasubramanian <pravb@microsoft.com>
Cc: Spencer Dawkins at IETF <spencerdawkins.ietf@gmail.com>, Jana Iyengar <jri.ietf@gmail.com>, Gorry Fairhurst <gorry@erg.abdn.ac.uk>, IETF QUIC WG <quic@ietf.org>, Neal Cardwell <ncardwell@google.com>, Yuchung Cheng <ycheng@google.com>
Content-Type: multipart/alternative; boundary="00000000000080ce4705aaa8e538"
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic/LGcVdAEoz725MbzIEp2aFgh347I>
X-BeenThere: quic@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Main mailing list of the IETF QUIC working group <quic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic>, <mailto:quic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic/>
List-Post: <mailto:quic@ietf.org>
List-Help: <mailto:quic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic>, <mailto:quic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Jul 2020 20:21:09 -0000

Thanks for the follow up comments and the excellent example Spencer.

Praveen, I agree that QUIC shouldn't require as many DC specific changes as
TCP, given it explicitly communicates max_ack_delay and there's no min RTO.

It seems there at least 4 options
1) Do nothing
2) Do nothing, but add a note that if you're on a managed network, some
requirements might not hold.
3) Change the MUST to a SHOULD
4) Use Neal's text or some variation thereof: "Implementations MUST either
use pacing or another method to limit such bursts. It is RECOMMENDED that
traffic over the public Internet limit bursts to the initial congestion
window; see Section 7.2."

I support softening this text some, given Linux today will burst well more
than 10 packets at once if the bandwidth is high enough.  Realistically, to
hit 1Gbps on a 5G network with QUIC, one might have to have bursts larger
than 10 packets, so I'm not sure this is only a DC issue.

I don't like the idea of saying you can change anything in the recovery doc
if you're on a managed network.  Obviously one can, but I'd be concerned
what might result.  Changing the MUST to a SHOULD is easy, but doesn't
provide any guidance on when it's ok to violate.  I'm hesitant to make a
distinction between public and private networks, partially because I do
think there are or will be valid cases for larger bursts on the public
internet.

I'm leaning towards saying you MUST limit bursts to IW unless the pacing
system can't provide enough sending opportunities to send at the rate
specified by the congestion controller.  Thoughts?

On Fri, Jul 17, 2020 at 12:41 PM Praveen Balasubramanian <
pravb@microsoft.com> wrote:

> AFAICT there is no RFC for TCP that limits burst sizes in general. I don’t
> think we need to special case Internet and DC networks. Changing the
> language from a MUST to a SHOULD is sufficient here. It leaves enough
> wiggle room for deployments and experimentation.
>
>
>
> I don’t see too many other changes needed in recovery draft for DC
> environment particularly now that there is no min rto. Jana, what other
> changes do you have in mind?
>
>
>
> *From:* Spencer Dawkins at IETF <spencerdawkins.ietf@gmail.com>
> *Sent:* Friday, July 17, 2020 5:21 AM
> *To:* Jana Iyengar <jri.ietf@gmail.com>
> *Cc:* Ian Swett <ianswett@google.com>; Praveen Balasubramanian <
> pravb@microsoft.com>; Gorry Fairhurst <gorry@erg.abdn.ac.uk>; IETF QUIC
> WG <quic@ietf.org>; Neal Cardwell <ncardwell@google.com>; Yuchung Cheng <
> ycheng@google.com>
> *Subject:* Re: [EXTERNAL] Re: WGLC review of draft-ietf-quic-recovery-29
>
>
>
> Hi, Jana,
>
>
>
> On Thu, Jul 16, 2020 at 8:30 PM Jana Iyengar <jri.ietf@gmail..com
> <jri.ietf@gmail.com>> wrote:
>
> At a high level, the recovery doc is _not_ written with DC environments in
> mind. We can make that clear in the document, if that helps. There are
> other things as well that won't work well in a DC environment, and I
> imagine a separate doc would be helpful here that specifies how QUIC ought
> to be tuned for DCs.
>
>
>
> Two things.
>
>
>
> My response to Ian was just about the history of what TSV has come to
> expect for encapsulation protocol behaviors in the past half-dozen years
> ("if you are doing stuff that's not safe on an unmanaged network, this is
> what you should do; if you're doing the same thing on a managed network,
> this is what you can probably get away with, and please point to your
> circuit breaker functionality in case what you're doing turns out to be a
> Really Bad Idea" - paraphrasing over a lot of subtilty).
>
>
>
> Those documents tended to have both cases in a single document, along with
> the rest of the encapsulation protocol, in many cases because the
> "unmanaged networks" considerations were being added to a single document
> that already described "managed networks" considerations.
>
>
>
> Pretty much every conversation I was involved in at QUIC charter time
> assumed that we would want to swap recovery functionality in and out over
> time without reopening draft-ietf-quic-transport, so having a separate
> recovery document was the right thing to do.
>
>
>
> Because QUIC already has a separate "safe for unmanaged networks" recovery
> document, I think putting other recovery strategies in separate documents
> is a fine plan.
>
>
>
> Does that make sense?
>
>
>
> Best,
>
>
>
> Spencer
>
>
>
> On Thu, Jul 16, 2020 at 2:18 PM Spencer Dawkins at IETF <
> spencerdawkins.ietf@gmail.com <spencerdawkins.ietf@gmail..com>> wrote:
>
> Hi, Ian,
>
>
>
> On Thu, Jul 16, 2020 at 2:22 PM Ian Swett <ianswett=
> 40google.com@dmarc.ietf.org> wrote:
>
> Thanks for the comments, I filed #3918
> <https://github..com/quicwg/base-drafts/issues/3918> and #3919
> <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fquicwg%2Fbase-drafts%2Fissues%2F3919&data=02%7C01%7Cpravb%40microsoft.com%7C3aec4cda750d49b8a7ef08d82a4bf551%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637305853016570346&sdata=akzKemBS1w2ASNuqfhCfXjV0PjkmtWJnD3NKm%2FWL%2BJg%3D&reserved=0>
>
>
>
>
> For my background, are you aware other transport RFCs have normative
> statements that only apply to the public internet?
>
>
>
> Tunnels are transport, right? :-)
>
>
>
> The earliest RFC I was involved with, that made distinctions about what
> you can get away with on the public internet versus in a managed network,
> was https://tools.ietf.org/html/rfc7510#section-5
> <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftools.ietf.org%2Fhtml%2Frfc7510%23section-5&data=02%7C01%7Cpravb%40microsoft.com%7C3aec4cda750d49b8a7ef08d82a4bf551%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637305853016580341&sdata=yS2XCONR3lZx10mfajWbppCDytE2DM1Y5Qc4r5uIyv0%3D&reserved=0>.
> This was negotiated after a fairly vigorous back-and-forth between
> transport people and non-transport people during IETF Last Call.
>
>
>
> We put together a design team with a few people to try to work through
> this for the myriad other protocols that people wanted to tunnel over UDP,
> once and for all.
>
>
>
> https://tools.ietf.org/html/rfc8084
> <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftools.ietf.org%2Fhtml%2Frfc8084&data=02%7C01%7Cpravb%40microsoft.com%7C3aec4cda750d49b8a7ef08d82a4bf551%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637305853016580341&sdata=GOTJobJC74eepsoltLYDssFu4%2FE8M1C97m173JHwdH0%3D&reserved=0>
> was published as a BCP.
>
>
>
> I may be forgetting other stuff, of course.
>
>
>
> Best,
>
>
>
> Spencer
>
>
>
> Also, if you're that well buffered and the bursts are that large, do you
> still start with IW10, or do you start with a larger window?
>
>
>
> Thanks, Ian
>
>