Re: [Rift] AD Review of draft-ietf-rift-rift-12 (Part 2a)

Antoni Przygienda <prz@juniper.net> Thu, 01 April 2021 20:26 UTC

Return-Path: <prz@juniper.net>
X-Original-To: rift@ietfa.amsl.com
Delivered-To: rift@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BD57C3A21F7; Thu, 1 Apr 2021 13:26:32 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.1
X-Spam-Level:
X-Spam-Status: No, score=-2.1 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=juniper.net header.b=Iaw+JNUO; dkim=pass (1024-bit key) header.d=juniper.net header.b=F7qshEtv
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dcv6NXbLt4ia; Thu, 1 Apr 2021 13:26:28 -0700 (PDT)
Received: from mx0b-00273201.pphosted.com (mx0b-00273201.pphosted.com [67.231.152.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 49E213A222A; Thu, 1 Apr 2021 13:26:28 -0700 (PDT)
Received: from pps.filterd (m0108160.ppops.net [127.0.0.1]) by mx0b-00273201.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 131KJpKf006933; Thu, 1 Apr 2021 13:26:26 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=PPS1017; bh=gMXw/VMC2YRC/uZhx3y4W/7J88QrT9vu8e+bmhx+Pxw=; b=Iaw+JNUOBe8EHeWYU+yg4K5DHqCwhd2Yt4WHMZa9SgSnSsWB8As/lmdaKj8MsuIFScXT S7AxV5MmKUWyqzQ2bEzgC+Taw6JNSNBya7AWXku93+Nx5/NP6hOg2seZJ4oDYkE2HPKn giJJnTOjAP1j0dtgUTdKiqHaerITgOjSLwXjIpNybcqEyeub8VpFoLUmxUkO6KMXS/Nb hqJKL0exu1P53xqI6ahrLbBw2jXvPkBZUK3xa4t4ReOZyhoIqOIrtInMK3LGDgfzjENo UVj2rKP3yPCVX8enigtQ9trt7cJog3EedE5kGkg4IGiUrZTQyapGlqsJTzKDUqdWT/1a fQ==
Received: from nam04-dm6-obe.outbound.protection.outlook.com (mail-dm6nam08lp2042.outbound.protection.outlook.com [104.47.73.42]) by mx0b-00273201.pphosted.com with ESMTP id 37n32yj4y0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 01 Apr 2021 13:26:26 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KdTN8v2QfBoHRLrRf7t4LfIUwGjKHBXgkslSUXbG3JDBtmRxdiOCd+26ZHd1G2ekQUghHnM3hzlDSyEEAJ3uFJb8ccUEPXacDcY48t3qYLgOy3hDKC8KiZK7EyqGjd9bckDCBlbAZGti7NAyaJB6svyiwNDvpObteurUrgOTsKWsBXmhJX/tTepMBob82lS/BPrAnLDdOdR3qGIG6MBQeDyjmjer0vTzLSppWVKH+KhvCEYZqWH1tA3tRzScO/MzYNdgSiuyydacD9pakL8DpxSgOLs2gsOfoxuGl4OQmXDB0ukVdvt2B3YQ2dAHc4ARdLggJCU9EELf9YIOvA7gSg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gMXw/VMC2YRC/uZhx3y4W/7J88QrT9vu8e+bmhx+Pxw=; b=b9/C9lJ2/Msoy/WkNoOSl3x/rQ9wu3r1y7Fx+sx/40X0c74q8JcNQjAXRvbQiU9OoPM7GoXMYud35Mo/1mI/W9yy7tghSCwQKcGPes7CLslxjWM1ljzIyxZ/JmjKdRs4p8Ej0pbtueNUfEGu/cxzreevTiyc+qoQae1NMSZEzkjl3wzMKJ/8zxiOanZs91IEj6uHvv46dc1KFiAhglEsPbp12cfSbtmMApZnUt1ZBmOx06pUXCCy5eDUTEI2eOOGLyKX8BMiwMkN59gXNa/tdOCEBd1vseCeYcF5IUWnUps3n4MXt4znptOWhN8+h1/hBGQVUJOjyzoVxxQbNICDyQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=juniper.net; dmarc=pass action=none header.from=juniper.net; dkim=pass header.d=juniper.net; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gMXw/VMC2YRC/uZhx3y4W/7J88QrT9vu8e+bmhx+Pxw=; b=F7qshEtvti5kYx/XdWkVyIRzsEsYC+l1+OrIGuJdVkqD9cf/7DrvFx2A4HEXA5RV1/FKK4yINjs4okZoLrCYqLO7GehnrKb0eosb6CsVMyHNaTTqrr1LBn9cXNimxqmGuZWbGXDL3m1Ncvz7PIZthpakCNYS09Fq8yw5jhNvwbY=
Received: from MWHPR0501MB3690.namprd05.prod.outlook.com (2603:10b6:301:7f::18) by CO1PR05MB8104.namprd05.prod.outlook.com (2603:10b6:303:da::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.8; Thu, 1 Apr 2021 20:26:24 +0000
Received: from MWHPR0501MB3690.namprd05.prod.outlook.com ([fe80::a9ea:18d2:51e2:a6da]) by MWHPR0501MB3690.namprd05.prod.outlook.com ([fe80::a9ea:18d2:51e2:a6da%7]) with mapi id 15.20.3999.027; Thu, 1 Apr 2021 20:26:23 +0000
From: Antoni Przygienda <prz@juniper.net>
To: Alvaro Retana <aretana.ietf@gmail.com>, Tony Przygienda <tonysietf@gmail.com>
CC: "draft-ietf-rift-rift@ietf.org" <draft-ietf-rift-rift@ietf.org>, "rift@ietf.org" <rift@ietf.org>, "rift-chairs@ietf.org" <rift-chairs@ietf.org>, "Jeffrey (Zhaohui) Zhang" <zzhang@juniper.net>
Thread-Topic: [Rift] AD Review of draft-ietf-rift-rift-12 (Part 2a)
Thread-Index: AQHXEdVMHrFaPT88PUWq2BSzdQsK96qgQeI1gAAmiQA=
Date: Thu, 01 Apr 2021 20:26:23 +0000
Message-ID: <43EB6E29-511A-4E0F-B834-53EC3994D18E@juniper.net>
References: <CAMMESsxBr0+UriSaTDVZMrFzU6DSiuC3-wO4+7HgX4nX7SLHmg@mail.gmail.com> <CA+wi2hNX2aFU2gYZp3JDGeSFdvWZSvJnJO2Gx3Ki-2ifOCvNeA@mail.gmail.com> <CAMMESswX=ENvZki2nuf6BF-2OxWS=NaoyAMrq5_jKSgS7cKuEw@mail.gmail.com>
In-Reply-To: <CAMMESswX=ENvZki2nuf6BF-2OxWS=NaoyAMrq5_jKSgS7cKuEw@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/16.47.21031401
msip_labels: MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Enabled=true; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_ContentBits=0; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_SiteId=bea78b3c-4cdb-4130-854a-1d193232e5f4; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_ActionId=a4392fd3-4f56-48c0-b4f2-6b3b812f5a91; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_SetDate=2021-04-01T20:25:35Z; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Method=Standard; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Name=Juniper Business Use Only;MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Enabled=true;
authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=juniper.net;
x-originating-ip: [66.129.239.13]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b8888b0c-fafb-4692-b515-08d8f54c6b51
x-ms-traffictypediagnostic: CO1PR05MB8104:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <CO1PR05MB81045069C92278FA0569021FAC7B9@CO1PR05MB8104.namprd05.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: Jb/N8RjpesM8WDAcOCfYQVDhG4L69GccMZxaCC/3fumeqpE7M0caKPUMuDZkW/13bmjGZRsdZI0n2WhSDeE13rmRYmxHWRpbrbC2DtvNf/kbQ4bwynzc95aHKm7rcMoqau8jrnBreuVhDwc3HdHdeuEUIGQVkFVramovmnmB+Klu6XbfzK/USiPi+48xKx5CEElR2FcEtOBrMOA5jVX+P0Ds2czqYqXdtI4r/aohgGJw11D4BaQz/aigZZ1ZLQCtjPeNXhWKTs+b7Pjk7Z/nliEuD0rAQjDHpqCR4TQWKvelXU0ff7/2+OstA2cVxHJQyQoVsGAp9A7vOAIfBeiEjObBpY8KQC9JQtSSkP92GAX9rRZo2qsNEnJPatSRA8lST28eVOKBtgoimBqT5ZJSGxTC3paWwhvZwkvk+AMbbnNaxif9NACxXyfgdoVU0oHYrMAogoNr8/h//W3+YyliBivhHlh/Dpto/aRFxUKCXztCqRqaGQLrxQhuLgeCBjddAMp7eMfehsqEXdco+TNXy34BIfE3PH0PJZPE+n0Cf7aLxqbJeNeLpuitXoimzkXAIS3oD502zN4e4D70JoKuMKtvczswa5cnvLkyY6AKpuFaJsI6DI1/N4Nq6DRpEWAbdB9G601ZHprUVUmgh9RvG+mu+/hSg0YRREUPadJMPGWBwgd/7asMtHAR5p+Z6Xcd
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR0501MB3690.namprd05.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(376002)(396003)(39860400002)(346002)(136003)(2906002)(4326008)(66946007)(66476007)(5660300002)(66556008)(38100700001)(91956017)(2616005)(76116006)(66446008)(6506007)(64756008)(478600001)(36756003)(8936002)(107886003)(71200400001)(6512007)(110136005)(83380400001)(54906003)(26005)(186003)(33656002)(6486002)(8676002)(86362001)(316002)(45980500001); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata: 8jdG/u9eZHgcnD/KMqsIhiGyq7pPrbzz1LBXbGrdcj+Yh5CC29EunRtOMaubYTkg5QvmvCgJm9dx/ITgEfyQulzEv8yu4xsziCFZZMPFAf0sVMOiWECY+a5Se/xtWqWOUDsHX9AqQk2Yq0REgygUguImlmGawpPMPQoU/5YLVXruIUnQkAqmI2JlTRMBuuow8LQN6CU/ds7UJ2Kgr0qWzJM0BHFY8RUveIf6efXS74Bo8ZOwwd9SC9lvGJBTdUGs247naPpPEwQvHi1iO7X2i29n6V4X3URAA9GDw57iIu+PfF4cQYNpGhJ/YNwHsTPlKLeM9Mz+rnUw9VLvVC5H0DtE1NIF60kCBto2ECbTgHEvczHqc/7rMIx9XdeIhu5B/heUuAA8EyCb4/4H+QO1ZbIkOSK5rD+FARMt5XK2VwC89H9YnRKH9hgWmcMog6pPIh7SbJsv35+P2KA+DeUTrUSyogLruvHwketgLW/XUWiOXOlCgs4tVqhITHuBY/EgfL0C6SX1CZSVWvGfi7BNIi/KUxyVGbO8JIPCEL8WNlRSclLD5QFVsj7emPlxuo0+dY8d2PX8cdNhSx//lIdFayPpy+8DPOKm7zPsVMYuIjlropVwgJLak+45Bzd7WH4b/kBmtzyWb0xO58BMut/fTX6k22zEpv5cFp3PU/z4oi3ovlKpwwz5C/0HunvMCcQEl8OaW4dVmQnByd0Jdy5ieh64SAKWrzZEokQEPSCX3Ty7Q6BSOOhjzB+C+syFmvY7ogbS8UM64eBzW51+aR8gRlk2xmAeV4n3mVJe3Hf4Z15yYjMPW2Lp6CZ8eqeUEjy/jg2fPipGUNDltgSzSUCrix/FI1JZAGecDwI213gUbRrmKoGQWCL7YopUdFiFluEG+CwNrGNHjzJQIIczqSw2O9xiQM18ypWZj8UqHN5l4sTDLZPxxtvljChlFhiXxgBS5wLsZQnopdnFi9jeqM2lJoBli6Ymb14rtSoCDgM9Vk+yC9SGksC2vbXZA82tFpjX3MEqohbJ0ZVVAS5EnKVYH7HGVX7HX0y7ClPdXngt4qC3xDmsaB/hGgOFtZx7zbwIfInfnrkxAR83p0tAWpMt68JurOH6uoUWyBdFsl5uFoSHnqQlmgNfNbp7JUmiKzKOufIePpBXhfq2vaIh1cf8SvevSdoApqtGiWK4GLNlYmWxx8NQla29bxzsh+tNEwJpuaQVURFs3YxpzR6unk3LZHGbCcUVdCcXj+xOpIbxCDilnYWD3U1V1sWhOGrhPQK/4mhdpoHzivGNKos9D/Z51rcXuwm4yUfCEdqT2ohUKFJlPmZ0oOUC4zN3JlENNUkD
Content-Type: text/plain; charset="utf-8"
Content-ID: <2FFB26E48C9770448FC6B9E13E3B0688@namprd05.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: juniper.net
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MWHPR0501MB3690.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b8888b0c-fafb-4692-b515-08d8f54c6b51
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2021 20:26:23.7722 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: bea78b3c-4cdb-4130-854a-1d193232e5f4
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: CZpKMN+jkARRimlpI1YRtI17v0ipisQ7gIxpc/1xH3us8O9xE9lVoi1Jzv80IdbO
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR05MB8104
X-Proofpoint-GUID: 5lS-9KyE0ZuHLScDLO5aVyIiabG_ZmLp
X-Proofpoint-ORIG-GUID: 5lS-9KyE0ZuHLScDLO5aVyIiabG_ZmLp
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369, 18.0.761 definitions=2021-04-01_10:2021-04-01, 2021-04-01 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 adultscore=0 mlxscore=0 priorityscore=1501 spamscore=0 bulkscore=0 phishscore=0 lowpriorityscore=0 mlxlogscore=999 impostorscore=0 clxscore=1015 suspectscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2103310000 definitions=main-2104010131
Archived-At: <https://mailarchive.ietf.org/arch/msg/rift/BLlXvCldDfBu21QfEofKgLiOYT0>
Subject: Re: [Rift] AD Review of draft-ietf-rift-rift-12 (Part 2a)
X-BeenThere: rift@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussion of Routing in Fat Trees <rift.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rift>, <mailto:rift-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rift/>
List-Post: <mailto:rift@ietf.org>
List-Help: <mailto:rift-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rift>, <mailto:rift-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Apr 2021 20:26:33 -0000

Ok, on 2nd thought I concur

-- tony

On 01/04/2021, 22:08, "Alvaro Retana" <aretana.ietf@gmail.com> wrote:

    [External Email. Be cautious of content]


    [+ authors, WG, Shepherd, Chairs]


    On March 7, 2021 at 3:56:09 PM, Tony Przygienda wrote:

    Tony:

    Hi!

    I have some replies to your answers (inline).

    Some of your answers point me to the schema -- which is ok, we had
    agreed on it being Normative.  But it makes me wonder, what are we
    standardizing?  I know we had talked about having the schema in the
    document -- but I don't think we're on the same page as to what that
    means.  I'm starting a separate thread with the WG (not everyone plays
    attention to the review threads), so let's please talk about it there.

    Thanks!

    Alvaro.



    ...
    > > 1341 4.2. Specification
    ...
    > > 1358 Any attempt to transition from a state towards another on reception
    > > 1359 of an event where no action is specified MUST be considered an
    > > 1360 unrecoverable error.
    ...
    > > [major] "MUST be considered an unrecoverable error" What is the result of
    > > that? Should the adjacencies be reset, the rift process restarted, the
    > > interfaces shut down, etc.?? There's no other place in the document that
    > > mentions "unrecoverable".
    >
    > implementation dependent. It's pretty much the same as the protocol throwing
    > a "core" or memory corruption. From that point behavior is unspecified but we
    > want it to be considered something that should not attempt a recovery. In
    > most stark terms don't even start RIFT again but we can't mandate any such
    > thing. It's implementation guidelines.

    Why can't you mandate that?  This is *the* spec! :-)

    If you need this behavior for interoperability (by using MUST), then
    you need to specify what the behavior is.  Yes, there are probably
    internals that you can't specify, but the external behavior is fair
    game: "all adjacencies MUST be reset and not be restarted" (or
    something like that).


    ...
    > > 1371 4.2.1. Transport
    > >
    > > 1373 All packet formats are defined in Thrift [thrift] models in
    > > 1374 Appendix B.
    > >
    > > [] Can we get an index/TOC or some type of guide in the appendix to make
    > > it easier to find specific parts? For example, finding where a LIE is
    > > defined is not straight forward -- I happened to stumble on it in B.2.
    > > Another option would be to point in §4.2.2 to look for LIEPacket in B.2.
    >
    > yes, as we said there will be a more extensive intro and a reader's guide


Juniper Business Use Only